Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32006 )
Change subject: fleex: Add VPD entry for deciding which touchscreen ACPI nodes to generate. ......................................................................
Patch Set 3:
(4 comments)
https://review.coreboot.org/#/c/32006/3/src/mainboard/google/octopus/variant... File src/mainboard/google/octopus/variants/fleex/overridetree.cb:
https://review.coreboot.org/#/c/32006/3/src/mainboard/google/octopus/variant... PS3, Line 125: register "vpd_string_tag" = ""touchscreen"" I don't think we should have these in the chip.h.
And, I think there's an issue with the namespace of the keys. A device could have multiple screens. So how do we know what 'touchscreen' ?
The key should be encode i2c controller path with the value of the hid below.
This should be 1:1 in what you'd see in sysfs on a booted system.
https://review.coreboot.org/#/c/32006/3/src/mainboard/google/octopus/variant... PS3, Line 126: register "vpd_string_value" = ""elan"" Why make this 'elan' and not just the hid? i.e. ELAN0001
https://review.coreboot.org/#/c/32006/3/src/vendorcode/google/chromeos/vpd_s... File src/vendorcode/google/chromeos/vpd_ssdt.h:
https://review.coreboot.org/#/c/32006/3/src/vendorcode/google/chromeos/vpd_s... PS3, Line 19: int vpd_should_generate_ssdt(const char *key, const char *value); What are the return values?
https://review.coreboot.org/#/c/32006/3/src/vendorcode/google/chromeos/vpd_s... File src/vendorcode/google/chromeos/vpd_ssdt.c:
https://review.coreboot.org/#/c/32006/3/src/vendorcode/google/chromeos/vpd_s... PS3, Line 4: Inc LLC