[coreboot-gerrit] [M] Change in coreboot[master]: mb/google/skyrim/var/winterhold: Change to read the eMMC clkreq instead

[Rex Chou (Code Review)]

Rex Chou has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/74598 )

Change subject: mb/google/skyrim/var/winterhold: Change to read the eMMC clkreq instead
......................................................................

mb/google/skyrim/var/winterhold: Change to read the eMMC clkreq instead

Because WD SSD drive isn't holding the clock low for some reason.
So we change to read eMMC clkreq signal instead.

BRANCH=none
BUG=b:274377518
TEST=emerge-skyrim coreboot chromeos-bootimage and verify ok.

Change-Id: If24314f0a12cbd6051b1884a5f585f5e3430cbd2
Signed-off-by: Rex Chou 
---
A 0001-comment76.patch
1 file changed, 62 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/98/74598/1

diff --git a/0001-comment76.patch b/0001-comment76.patch
new file mode 100644
index 0000000..34217c1
--- /dev/null
+++ b/0001-comment76.patch
@@ -0,0 +1,45 @@
+From 45d636a6af281802802f27ca8ba8b5f0f934bb7f Mon Sep 17 00:00:00 2001
+From: EricKY Cheng 
+Date: Thu, 20 Apr 2023 17:21:24 +0800
+Subject: [PATCH] comment76
+
+Change-Id: I1329386631dc54209db54ac146e4aafe95b6a3ac
+---
+ .../skyrim/variants/winterhold/port_descriptors.c    | 12 ++++++------
+ 1 file changed, 6 insertions(+), 6 deletions(-)
+
+diff --git a/src/mainboard/google/skyrim/variants/winterhold/port_descriptors.c b/src/mainboard/google/skyrim/variants/winterhold/port_descriptors.c
+index 37edb0261a..bee7691e67 100644
+--- a/src/mainboard/google/skyrim/variants/winterhold/port_descriptors.c
++++ b/src/mainboard/google/skyrim/variants/winterhold/port_descriptors.c
+@@ -74,7 +74,7 @@ static const fsp_dxio_descriptor nvme_dxio_descriptors[] = {
+ 	},
+ };
+ 
+-#define NVME_CLKREQ_GPIO 92
++#define EMMC_CLKREQ_GPIO 115
+ void variant_get_dxio_descriptor(const fsp_dxio_descriptor **dxio_descs, size_t *dxio_num)
+ {
+ 	/*
+@@ -85,13 +85,13 @@ void variant_get_dxio_descriptor(const fsp_dxio_descriptor **dxio_descs, size_t
+ 	 * This allows checking the state of the NVMe device clkreq signal and enabling
+ 	 * either eMMC or NVMe based on that.
+ 	 */
+-	if (gpio_get(NVME_CLKREQ_GPIO)) {
+-		printk(BIOS_DEBUG, "Enabling eMMC.\n");
+-		*dxio_num = ARRAY_SIZE(emmc_dxio_descriptors);
+-		*dxio_descs = emmc_dxio_descriptors;
+-	} else {
++	if (gpio_get(EMMC_CLKREQ_GPIO)) {
+ 		printk(BIOS_DEBUG, "Enabling NVMe.\n");
+ 		*dxio_num = ARRAY_SIZE(nvme_dxio_descriptors);
+ 		*dxio_descs = nvme_dxio_descriptors;
++	} else {
++		printk(BIOS_DEBUG, "Enabling eMMC.\n");
++		*dxio_num = ARRAY_SIZE(emmc_dxio_descriptors);
++		*dxio_descs = emmc_dxio_descriptors;
+ 	}
+ }
+-- 
+2.39.2
+