25 Jul
2020
25 Jul
'20
1:22 a.m.
Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43623 )
Change subject: mb/system76/lemp9: enable I2C HID touchpad ......................................................................
Patch Set 19:
(1 comment)
https://review.coreboot.org/c/coreboot/+/43623/8/src/mainboard/system76/lemp... File src/mainboard/system76/lemp9/gpio.h:
https://review.coreboot.org/c/coreboot/+/43623/8/src/mainboard/system76/lemp... PS8, Line 143: PAD_CFG_GPI_APIC(GPP_B3, NONE, PLTRST, EDGE_SINGLE, INVERT),
Isn't this the same as `PAD_CFG_GPI_APIC_EDGE_LOW(GPP_B3, NONE, PLTRST)` ?
yes, it is...
--
To view, visit https://review.coreboot.org/c/coreboot/+/43623
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic3a90fda134b1d53f28ab687b3033ec52fee843b
Gerrit-Change-Number: 43623
Gerrit-PatchSet: 19
Gerrit-Owner: Jeremy Soller jeremy@system76.com
Gerrit-Reviewer: Michael Niewöhner
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Fri, 24 Jul 2020 23:22:32 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons th3fanbus@gmail.com
Gerrit-MessageType: comment