Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34788 )
Change subject: mb/google/hatch/var/kindred: Config GPIOs and disable eMMC for SSD SKUs
......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/34788/2/src/mainboard/google/hatch/...
File src/mainboard/google/hatch/variants/kindred/gpio.c:
https://review.coreboot.org/c/coreboot/+/34788/2/src/mainboard/google/hatch/...
PS2, Line 137: switch (sku_id) {
All of the cases (except for default) have the same body - they all use ssd_sku_gpio_table. […]
Agreed, for this commit, please keep all identical cases together; it's also appreciated to add a nice big comment as to why all the case statements are falling through together.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/34788
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I0d893f0f7339e7b1a1e6b56d1598c0a361c8d604
Gerrit-Change-Number: 34788
Gerrit-PatchSet: 2
Gerrit-Owner: David Wu
david_wu@quanta.corp-partner.google.com
Gerrit-Reviewer: David Wu
david_wu@quanta.corp-partner.google.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Paul Fagerburg
pfagerburg@google.com
Gerrit-Reviewer: Philip Chen
philipchen@google.com
Gerrit-Reviewer: Shelley Chen
shchen@google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Fagerburg
pfagerburg@chromium.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Mon, 12 Aug 2019 15:59:14 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Fagerburg
pfagerburg@chromium.org
Gerrit-MessageType: comment