build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31448 )
Change subject: src/device/pci: Add support for discrete VGA initialization and OpROM loading ......................................................................
Patch Set 11:
(7 comments)
https://review.coreboot.org/#/c/31448/11/src/device/pci_device.c File src/device/pci_device.c:
https://review.coreboot.org/#/c/31448/11/src/device/pci_device.c@830 PS11, Line 830: pci_class == PCI_CLASS_DISPLAY_VGA ? "Integrated" : "Discrete"); line over 80 characters
https://review.coreboot.org/#/c/31448/11/src/device/pci_device.c@837 PS11, Line 837: pci_class == PCI_CLASS_DISPLAY_VGA ? "Integrated" : "Discrete"); line over 80 characters
https://review.coreboot.org/#/c/31448/11/src/device/pci_rom.c File src/device/pci_rom.c:
https://review.coreboot.org/#/c/31448/11/src/device/pci_rom.c@188 PS11, Line 188: /* Set the start of shadow memory for this Integrated or Discrete VGA. */ line over 80 characters
https://review.coreboot.org/#/c/31448/11/src/device/pci_rom.c@189 PS11, Line 189: switch (dev->class >> 8) { switch and case should be at the same indent
https://review.coreboot.org/#/c/31448/11/src/device/pci_rom.c@191 PS11, Line 191: run_rom = (struct rom_header *)(uintptr_t)PCI_VGA_RAM_IMAGE_START; line over 80 characters
https://review.coreboot.org/#/c/31448/11/src/device/pci_rom.c@195 PS11, Line 195: run_rom = (struct rom_header *)(uintptr_t)PCI_RAM_IMAGE_START; line over 80 characters
https://review.coreboot.org/#/c/31448/11/src/device/pci_rom.c@272 PS11, Line 272: switch (device->class >> 8) { switch and case should be at the same indent