[coreboot-gerrit] Change in ...coreboot[master]: soc/intel/apollolake: Override GLK usb clock gating register

[Furquan Shaikh (Code Review)]

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30918 )

Change subject: soc/intel/apollolake: Override GLK usb clock gating register
......................................................................

Patch Set 3:

(3 comments)

https://review.coreboot.org/#/c/30918/3/src/soc/intel/apollolake/chip.c 
File src/soc/intel/apollolake/chip.c:

https://review.coreboot.org/#/c/30918/3/src/soc/intel/apollolake/chip.c@64 
PS3, Line 64: ///
Please follow commenting guidelines here: https://www.coreboot.org/Coding_Style#Commenting

https://review.coreboot.org/#/c/30918/3/src/soc/intel/apollolake/chip.c@64 
PS3, Line 64: BIT28
Can you please follow the same convention as rest of the file i.e. use (1 << 28) instead of BIT28?

https://review.coreboot.org/#/c/30918/3/src/soc/intel/apollolake/chip.c@772 
PS3, Line 772: uint32_t *cfg;
             : 	const struct resource *res;
             : 	uint32_t reg;
             : 	struct device *xhci_dev = PCH_DEV_XHCI;
These could potentially be moved to the if block being added at line 808.