Attention is currently required from: Tarun Tuli, Subrata Banik, Eric Lai.
Kapil Porwal has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/73121 )
Change subject: mb/google/rex: Set audio GPIOs based on fw_config
......................................................................
Patch Set 5:
(2 comments)
This change is ready for review.
Patchset:
PS3:
do u want to remove I2S/SNDW GPIO configuration alongwith this CL from variant gpio. […]
They are enabled/configured in gpio.c and we are disabling them in fw_config.c if they are not required.
File src/mainboard/google/rex/fw_config.c:
https://review.coreboot.org/c/coreboot/+/73121/comment/6b6093d7_148bfe3d
PS2, Line 89: BOOT_STATE_INIT_ENTRY(BS_DEV_ENABLE, BS_ON_ENTRY, fw_config_handle, NULL);
oh, I though we want all the board do the gpio in their variant. That can work too.
Ack
--
To view, visit
https://review.coreboot.org/c/coreboot/+/73121
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I0ed452a0d08e6779add318d9bbd1e97b50b6aea9
Gerrit-Change-Number: 73121
Gerrit-PatchSet: 5
Gerrit-Owner: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Tarun Tuli
taruntuli@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Tarun Tuli
taruntuli@google.com
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-Comment-Date: Tue, 21 Feb 2023 13:59:44 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Subrata Banik
subratabanik@google.com
Comment-In-Reply-To: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-MessageType: comment