Attention is currently required from: Furquan Shaikh, Angel Pons.
Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41122 )
Change subject: cbfstool: Add support for platform "fixups" when modifying bootblock
......................................................................
Patch Set 21:
(2 comments)
File util/cbfstool/platform_fixups.c:
https://review.coreboot.org/c/coreboot/+/41122/comment/cf4c7150_b8424df9
PS21, Line 17: 32KB
nit: KiB?
Done
https://review.coreboot.org/c/coreboot/+/41122/comment/d6b1e8ce_02d3c6cc
PS21, Line 47: (int)
What is the purpose of this cast to int?
Just to make the two sides comparable (the other side is (int) because of integer promotion).
--
To view, visit
https://review.coreboot.org/c/coreboot/+/41122
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I02a83a40f1d0009e6f9561ae5d2d9f37a510549a
Gerrit-Change-Number: 41122
Gerrit-PatchSet: 21
Gerrit-Owner: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Attention: Furquan Shaikh
furquan@google.com
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Comment-Date: Sat, 13 Feb 2021 02:23:22 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment