9 Jul
2019
9 Jul
'19
4:34 p.m.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34138 )
Change subject: mainboard/toshiba/satellite_u940: do initial commit ......................................................................
Patch Set 7:
(1 comment)
https://review.coreboot.org/c/coreboot/+/34138/7/src/mainboard/toshiba/satel... File src/mainboard/toshiba/satellite_u940/romstage.c:
https://review.coreboot.org/c/coreboot/+/34138/7/src/mainboard/toshiba/satel... PS7, Line 72: /* FIXME: Put proper SPD map here. */ According to schematics, the two slots' SPDs are on 0x50 and 0x52. You can remove the other two lines.
--
To view, visit https://review.coreboot.org/c/coreboot/+/34138
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If87c327cd15fe44479d6738c45acbd510873d994
Gerrit-Change-Number: 34138
Gerrit-PatchSet: 7
Gerrit-Owner: Fran Lego new.francisco.1998@tuta.io
Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: Fran Lego new.francisco.1998@tuta.io
Gerrit-Reviewer: Idwer Vollering vidwer@gmail.com
Gerrit-Reviewer: Martin Roth martinroth@google.com
Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Tue, 09 Jul 2019 14:34:07 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment