Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36447 )
Change subject: mainboard/google/hatch: Create helios_diskswap variant ......................................................................
Patch Set 4: Code-Review+2
Patch Set 4:
Patch Set 4:
Patch Set 4:
Is anything else needed here?
I'm confused as to why this project (helios_diskwap) needs a whole new coreboot target, when, as far as I can see, it would be just a few patches you could carry in your local tree. Am I missing something?
For my testing purposes, that is basically what I have been doing, but at this point we want to do an expanded experiment with official images. Because it needs the different BIOS image to enable the 2x2 pcie config, Furquan suggested adding a new coreboot target. If there is another way of doing this please let me know.
I would just keep a collection of local patches for helios (unless you need to build both for some reason), but I trust Furquan.