Attention is currently required from: Philipp Hug, Julius Werner, ron minnich.
Elyes Haouas has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/69816 )
Change subject: src/arch: Remove unnecessary space after casts ......................................................................
src/arch: Remove unnecessary space after casts
Change-Id: I00551dfd963d47a58284bc31f21b0fa12130fe78 Signed-off-by: Elyes Haouas ehaouas@noos.fr --- M src/arch/arm/eabi_compat.c M src/arch/arm/libgcc/umoddi3.c M src/arch/riscv/trap_handler.c M src/arch/x86/cpu.c M src/arch/x86/memset.c M src/arch/x86/pirq_routing.c 6 files changed, 19 insertions(+), 9 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/16/69816/1
diff --git a/src/arch/arm/eabi_compat.c b/src/arch/arm/eabi_compat.c index cbc285c..2a110d5 100644 --- a/src/arch/arm/eabi_compat.c +++ b/src/arch/arm/eabi_compat.c @@ -26,11 +26,11 @@ void __aeabi_memcpy(void *dest, const void *src, size_t n); void __aeabi_memcpy(void *dest, const void *src, size_t n) { - (void) memcpy(dest, src, n); + (void)memcpy(dest, src, n); }
void __aeabi_memset(void *dest, size_t n, int c); void __aeabi_memset(void *dest, size_t n, int c) { - (void) memset(dest, c, n); + (void)memset(dest, c, n); } diff --git a/src/arch/arm/libgcc/umoddi3.c b/src/arch/arm/libgcc/umoddi3.c index 5d2ede7..c84e9e4 100644 --- a/src/arch/arm/libgcc/umoddi3.c +++ b/src/arch/arm/libgcc/umoddi3.c @@ -4,6 +4,6 @@ uint64_t __umoddi3(uint64_t num, uint64_t den) { uint64_t v; - (void) __udivmoddi4(num, den, &v); + (void)__udivmoddi4(num, den, &v); return v; } diff --git a/src/arch/riscv/trap_handler.c b/src/arch/riscv/trap_handler.c index f940f63..53049fd 100644 --- a/src/arch/riscv/trap_handler.c +++ b/src/arch/riscv/trap_handler.c @@ -64,8 +64,8 @@ previous_mode, mprv? " (MPRV)":""); printk(BIOS_DEBUG, "Bad instruction pc: %p\n", (void *)tf->epc); printk(BIOS_DEBUG, "Bad address: %p\n", (void *)tf->badvaddr); - printk(BIOS_DEBUG, "Stored ra: %p\n", (void*) tf->gpr[1]); - printk(BIOS_DEBUG, "Stored sp: %p\n", (void*) tf->gpr[2]); + printk(BIOS_DEBUG, "Stored ra: %p\n", (void*)tf->gpr[1]); + printk(BIOS_DEBUG, "Stored sp: %p\n", (void*)tf->gpr[2]); }
static void interrupt_handler(trapframe *tf) diff --git a/src/arch/x86/cpu.c b/src/arch/x86/cpu.c index 6a8ddef..9fc5233 100644 --- a/src/arch/x86/cpu.c +++ b/src/arch/x86/cpu.c @@ -59,7 +59,7 @@ : "cc");
/* AH is 0x02 on Cyrix after the divide.. */ - return (unsigned char) (test >> 8) == 0x02; + return (unsigned char)(test >> 8) == 0x02; }
/* diff --git a/src/arch/x86/memset.c b/src/arch/x86/memset.c index fc09a9b..8a0165b 100644 --- a/src/arch/x86/memset.c +++ b/src/arch/x86/memset.c @@ -12,7 +12,7 @@ void *memset(void *dstpp, int c, size_t len) { int d0; - unsigned long int dstp = (unsigned long int) dstpp; + unsigned long int dstp = (unsigned long int)dstpp;
#if (ENV_ROMSTAGE && CONFIG(ASAN_IN_ROMSTAGE)) || \ (ENV_RAMSTAGE && CONFIG(ASAN_IN_RAMSTAGE)) @@ -22,7 +22,7 @@ /* This explicit register allocation improves code very much indeed. */ register op_t x asm("ax");
- x = (unsigned char) c; + x = (unsigned char)c;
/* Clear the direction flag, so filling will move forward. */ asm volatile("cld"); diff --git a/src/arch/x86/pirq_routing.c b/src/arch/x86/pirq_routing.c index 362650d..0da057f 100644 --- a/src/arch/x86/pirq_routing.c +++ b/src/arch/x86/pirq_routing.c @@ -17,7 +17,7 @@ if (sizeof(struct irq_routing_table) != rt->size) { printk(BIOS_WARNING, "Inconsistent Interrupt Routing Table size (0x%x/0x%x).\n", - (unsigned int) sizeof(struct irq_routing_table), + (unsigned int)sizeof(struct irq_routing_table), rt->size); rt->size = sizeof(struct irq_routing_table); }