Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35408 )
Change subject: [WIP] security/vboot: Fix regression with VBOOT_STARTS_IN_ROMSTAGE
......................................................................
Patch Set 2: Code-Review+1
(2 comments)
https://review.coreboot.org/c/coreboot/+/35408/2//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/35408/2//COMMIT_MSG@7
PS2, Line 7: [WIP]
remove the [wip]?
https://review.coreboot.org/c/coreboot/+/35408/2/src/include/rules.h
File src/include/rules.h:
https://review.coreboot.org/c/coreboot/+/35408/2/src/include/rules.h@271
PS2, Line 271: ROMSTAGE
Make this positive logic by using the BOOTBLOCK Kconfig option?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/35408
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Idc274409c495efea95eeecd0538b2f8b847970ad
Gerrit-Change-Number: 35408
Gerrit-PatchSet: 2
Gerrit-Owner: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Frans Hendriks
fhendriks@eltan.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Sun, 15 Sep 2019 21:00:36 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment