Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34786 )
Change subject: mb/toshiba: Add A300-1ME ......................................................................
Patch Set 4:
(1 comment)
This change is ready for review.
https://review.coreboot.org/c/coreboot/+/34786/3/src/mainboard/toshiba/a300-... File src/mainboard/toshiba/a300-1me/acpi/ich9_pci_irqs.asl:
https://review.coreboot.org/c/coreboot/+/34786/3/src/mainboard/toshiba/a300-... PS3, Line 24: // PCI Slot 1 routes ABCD : Package() { 0x0000ffff, 0, 0, 16}, : Package() { 0x0000ffff, 1, 0, 17}, : Package() { 0x0000ffff, 2, 0, 18}, : Package() { 0x0000ffff, 3, 0, 19}, : : // PCI Slot 2 routes BCDA : Package() { 0x0001ffff, 0, 0, 17}, : Package() { 0x0001ffff, 1, 0, 18}, : Package() { 0x0001ffff, 2, 0, 19}, : Package() { 0x0001ffff, 3, 0, 16}, : : // PCI Slot 3 routes CDAB : Package() { 0x0002ffff, 0, 0, 18}, : Package() { 0x0002ffff, 1, 0, 19}, : Package() { 0x0002ffff, 2, 0, 16}, : Package() { 0x0002ffff, 3, 0, 17}, : : // PCI Slot 4 routes ABCD : Package() { 0x0003ffff, 0, 0, 16}, : Package() { 0x0003ffff, 1, 0, 17}, : Package() { 0x0003ffff, 2, 0, 18}, : Package() { 0x0003ffff, 3, 0, 19}, : : // PCI Slot 5 routes ABCD : Package() { 0x0004ffff, 0, 0, 16}, : Package() { 0x0004ffff, 1, 0, 17}, : Package() { 0x0004ffff, 2, 0, 18}, : Package() { 0x0004ffff, 3, 0, 19}, : : // PCI Slot 6 routes BCDA : Package() { 0x0005ffff, 0, 0, 17}, : Package() { 0x0005ffff, 1, 0, 18}, : Package() { 0x0005ffff, 2, 0, 19}, : Package() { 0x0005ffff, 3, 0, 16}, : : // FIXME: what's this supposed to mean? (adopted from ich7) : //Package() { 0x0008ffff, 0, 0, 20},
This is likely wrong.
Indeed it was. Fixed.