30 Sep
2020
30 Sep
'20
7:16 p.m.
ron minnich has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44686 )
Change subject: security/intel/stm: Add options for STM build ......................................................................
Patch Set 12: Code-Review+2
With the proviso that I have no way to test, this looks good.
I do wish we did not rely on cmake, is that absolutely necessary?
--
To view, visit https://review.coreboot.org/c/coreboot/+/44686
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I80ed7cbcb93468c5ff93d089d77742ce7b671a37
Gerrit-Change-Number: 44686
Gerrit-PatchSet: 12
Gerrit-Owner: Eugene Myers cedarhouse1@comcast.net
Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: Eugene Myers cedarhouse@comcast.net
Gerrit-Reviewer: Martin Roth martinroth@google.com
Gerrit-Reviewer: Nico Huber nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org
Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Reviewer: ron minnich rminnich@gmail.com
Gerrit-Comment-Date: Wed, 30 Sep 2020 17:16:15 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment