[coreboot-gerrit] [S] Change in coreboot[main]: drivers/spi/acpi: Add generic property list

[Felix Held (Code Review)]

Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/83139?usp=email )

(

9 is the latest approved patch-set.
No files were changed between the latest approved patch-set and the submitted one.
 )Change subject: drivers/spi/acpi: Add generic property list
......................................................................

drivers/spi/acpi: Add generic property list

The touchscreen vendor (Goodix) needs to use this value
(hid-report-addr) in the touch driver, and this value
needs to be changed later.So add generic property list to allow populating vendor specific device properties to ACPI SSDT table.

BUG=b:342932183
BRANCH=None
TEST=emerge-brox coreboot

Change-Id: I8b18e0a2925e6fd36e3a470bde9910661b7558b8
Signed-off-by: Kun Liu 
Reviewed-on: https://review.coreboot.org/c/coreboot/+/83139
Reviewed-by: Karthik Ramasubramanian 
Tested-by: build bot (Jenkins) 
---
M src/drivers/spi/acpi/acpi.c
M src/drivers/spi/acpi/chip.h
2 files changed, 9 insertions(+), 1 deletion(-)

Approvals:
  Karthik Ramasubramanian: Looks good to me, approved
  build bot (Jenkins): Verified

diff --git a/src/drivers/spi/acpi/acpi.c b/src/drivers/spi/acpi/acpi.c
index 6d92776..687dd52 100644
--- a/src/drivers/spi/acpi/acpi.c
+++ b/src/drivers/spi/acpi/acpi.c
@@ -131,7 +131,7 @@

/* Write device properties if needed */
    if (config->compat_string || irq_gpio_index >= 0 ||
-	    reset_gpio_index >= 0 || enable_gpio_index >= 0) {
+	    reset_gpio_index >= 0 || enable_gpio_index >= 0 || config->property_count) {
    	struct acpi_dp *dsd = acpi_dp_new_table("_DSD");
    	if (config->compat_string)
    		acpi_dp_add_string(dsd, "compatible",
@@ -148,6 +148,9 @@
    		acpi_dp_add_gpio(dsd, "enable-gpios", path,
    				 enable_gpio_index, 0,
    				 config->enable_gpio.active_low);
+		/* Add generic property list */
+		acpi_dp_add_property_list(dsd, config->property_list,
+					 config->property_count);
    	acpi_dp_write(dsd);
    }

diff --git a/src/drivers/spi/acpi/chip.h b/src/drivers/spi/acpi/chip.h
index 9bee847..b7b39f7 100644
--- a/src/drivers/spi/acpi/chip.h
+++ b/src/drivers/spi/acpi/chip.h
@@ -5,6 +5,8 @@

#include <acpi/acpi_device.h>

+#define MAX_GENERIC_PROPERTY_LIST 10
+
 struct drivers_spi_acpi_config {
    const char *hid;		/* ACPI _HID (required) */
    const char *cid;		/* ACPI _CID */
@@ -42,6 +44,9 @@
    unsigned int stop_delay_ms;
    /* Delay to be inserted after enabling stop. */
    unsigned int stop_off_delay_ms;
+	/* Generic properties for exporting device-specific data to the OS */
+	struct acpi_dp property_list[MAX_GENERIC_PROPERTY_LIST];
+	unsigned int property_count;
 };

#endif /* __SPI_ACPI_CHIP_H__ */