Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32485 )
Change subject: soc/intel/common: Add new PAD_CFG macro.
......................................................................
Patch Set 3:
(1 comment)
Patch Set 3:
Okay to assume IOAPIC and SCI for the _IRQ_WAKE() macro?
Yes. That was the intent of the marco. _IRQ_ is a bit confusing name, hence I suggesting changing IOAPIC_SCI. IRQ could mean legacy GPIO_IRQ or APIC as well.
https://review.coreboot.org/#/c/32485/3//COMMIT_MSG
Commit Message:
https://review.coreboot.org/#/c/32485/3//COMMIT_MSG@11
PS3, Line 11:
Commit message doesn't reflect the other change that is being made. It would be good to mention that too.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/32485
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I0332c64e2fa62ce29c772444606adbfdf9c9afc4
Gerrit-Change-Number: 32485
Gerrit-PatchSet: 3
Gerrit-Owner: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Shelley Chen
shchen@google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Fri, 26 Apr 2019 23:28:23 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment