Attention is currently required from: Maulik V Vaghela, Tim Wawrzynczak, Patrick Rudolph. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59666 )
Change subject: soc/intel/alderlake: Implement function to map physical port to EC port ......................................................................
Patch Set 3: Verified-1
(5 comments)
File src/soc/intel/alderlake/retimer.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134329): https://review.coreboot.org/c/coreboot/+/59666/comment/a851960c_24c72246 PS3, Line 20: for (uint8_t i = 0; i < MAX_TYPE_C_PORTS; i++) that open brace { should be on the previous line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134329): https://review.coreboot.org/c/coreboot/+/59666/comment/2ec8ea88_73511f29 PS3, Line 28: ec_port++; code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134329): https://review.coreboot.org/c/coreboot/+/59666/comment/73d3f4ea_a89c4b4a PS3, Line 28: ec_port++; please, no space before tabs
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134329): https://review.coreboot.org/c/coreboot/+/59666/comment/9fab7544_18d42ddc PS3, Line 28: ec_port++; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134329): https://review.coreboot.org/c/coreboot/+/59666/comment/5b02e7a2_babf5fa2 PS3, Line 32: die("Couldn't find correct port mapping or Invalid input port \n"); unnecessary whitespace before a quoted newline