Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35542 )
Change subject: soc/intel/skylake: devicetree: introduce PchHdaVcType fsp parameter
......................................................................
Patch Set 12:
Patch Set 12:
I'm still curious why it needs to be one on some boards, even if the HDA is disabled. For me it sounds like a bug that's triggered somehow.
Yeah, I guess this is a bug in FSP, so we only should set this when needed; I've added more info to https://github.com/IntelFsp/FSP/issues/30
--
To view, visit
https://review.coreboot.org/c/coreboot/+/35542
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ibafc3b6bd2495658f2bd634218042ec413a89f5e
Gerrit-Change-Number: 35542
Gerrit-PatchSet: 12
Gerrit-Owner: Michael Niewöhner
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Maxim Polyakov
max.senia.poliak@gmail.com
Gerrit-Reviewer: Michael Niewöhner
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Tue, 01 Oct 2019 18:31:02 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment