[coreboot-gerrit] Change in coreboot[master]: amd/fam*/northbridge.c: Remove unused reset_memhole variable

[Arthur Heymans (Code Review)]

Attention is currently required from: Arthur Heymans.
Hello Arthur Heymans,

I'd like you to do a code review. Please visit

https://review.coreboot.org/c/coreboot/+/63042

to review the following change.

Change subject: amd/fam*/northbridge.c: Remove unused reset_memhole variable
......................................................................

amd/fam*/northbridge.c: Remove unused reset_memhole variable

Change-Id: I9231e0399d0b3ac6a608282571fc6d4aefad9dfb
Signed-off-by: Arthur Heymans 
---
M src/northbridge/amd/agesa/family14/northbridge.c
M src/northbridge/amd/agesa/family15tn/northbridge.c
M src/northbridge/amd/agesa/family16kb/northbridge.c
3 files changed, 3 insertions(+), 12 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/42/63042/1

diff --git a/src/northbridge/amd/agesa/family14/northbridge.c b/src/northbridge/amd/agesa/family14/northbridge.c
index 77e68d8..3507ff7 100644
--- a/src/northbridge/amd/agesa/family14/northbridge.c
+++ b/src/northbridge/amd/agesa/family14/northbridge.c
@@ -510,7 +510,6 @@
    struct bus *link;
 #if CONFIG_HW_MEM_HOLE_SIZEK != 0
    struct hw_mem_hole_info mem_hole;
-	u32 reset_memhole = 1;
 #endif

pci_tolm = 0xffffffffUL;
@@ -539,10 +538,8 @@
    mem_hole = get_hw_mem_hole_info();

// Use hole_basek as mmio_basek, and we don't need to reset hole anymore
-	if ((mem_hole.node_id != -1) && (mmio_basek > mem_hole.hole_startk)) {
+	if ((mem_hole.node_id != -1) && (mmio_basek > mem_hole.hole_startk))
    	mmio_basek = mem_hole.hole_startk;
-		reset_memhole = 0;
-	}
 #endif

idx = 0x10;
diff --git a/src/northbridge/amd/agesa/family15tn/northbridge.c b/src/northbridge/amd/agesa/family15tn/northbridge.c
index 65be7d8..d36c9d4 100644
--- a/src/northbridge/amd/agesa/family15tn/northbridge.c
+++ b/src/northbridge/amd/agesa/family15tn/northbridge.c
@@ -668,7 +668,6 @@
    struct bus *link;
 #if CONFIG_HW_MEM_HOLE_SIZEK != 0
    struct hw_mem_hole_info mem_hole;
-	u32 reset_memhole = 1;
 #endif

pci_tolm = 0xffffffffUL;
@@ -697,10 +696,8 @@
    mem_hole = get_hw_mem_hole_info();

// Use hole_basek as mmio_basek, and we don't need to reset hole anymore
-	if ((mem_hole.node_id !=  -1) && (mmio_basek > mem_hole.hole_startk)) {
+	if ((mem_hole.node_id !=  -1) && (mmio_basek > mem_hole.hole_startk))
    	mmio_basek = mem_hole.hole_startk;
-		reset_memhole = 0;
-	}
 #endif

idx = 0x10;
diff --git a/src/northbridge/amd/agesa/family16kb/northbridge.c b/src/northbridge/amd/agesa/family16kb/northbridge.c
index 1c63092..170a0d2 100644
--- a/src/northbridge/amd/agesa/family16kb/northbridge.c
+++ b/src/northbridge/amd/agesa/family16kb/northbridge.c
@@ -680,7 +680,6 @@
    struct bus *link;
 #if CONFIG_HW_MEM_HOLE_SIZEK != 0
    struct hw_mem_hole_info mem_hole;
-	u32 reset_memhole = 1;
 #endif

pci_tolm = 0xffffffffUL;
@@ -709,10 +708,8 @@
    mem_hole = get_hw_mem_hole_info();

// Use hole_basek as mmio_basek, and we don't need to reset hole anymore
-	if ((mem_hole.node_id !=  -1) && (mmio_basek > mem_hole.hole_startk)) {
+	if ((mem_hole.node_id !=  -1) && (mmio_basek > mem_hole.hole_startk))
    	mmio_basek = mem_hole.hole_startk;
-		reset_memhole = 0;
-	}
 #endif

idx = 0x10;