Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34642 )
Change subject: soc/intel/apl: Enable FSP usage by default ......................................................................
Patch Set 3: Code-Review+1
(1 comment)
https://review.coreboot.org/c/coreboot/+/34642/3/src/soc/intel/apollolake/Kc... File src/soc/intel/apollolake/Kconfig:
https://review.coreboot.org/c/coreboot/+/34642/3/src/soc/intel/apollolake/Kc... PS3, Line 194: config ADD_FSP_BINARIES : bool : default y : : config FSP_USE_REPO : bool : default y Meh, missed something: GLK is not in the Github FSP, it seems, so this should depend on !SOC_INTEL_GLK.
Also, the former could always `default y if FSP_USE_REPO` independent of the platform, I guess.