Attention is currently required from: Rex-BC Chen, Paul Menzel, Yu-Ping Wu.
Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56106 )
Change subject: vc/mediatek/mt8195: Enable DRAM Vcore DVFS settings
......................................................................
Patch Set 8:
(1 comment)
File src/vendorcode/mediatek/mt8195/dramc/dramc_pi_main.c:
https://review.coreboot.org/c/coreboot/+/56106/comment/455849b2_9b207bbc
PS7, Line 275: print("Vio18 = %d\n", dramc_get_vio18_voltage());
vio18 is fixed at 1.8 volts, it will not be adjusted during dram init, […]
So it'll simply show 0? given it's only for debugging I think it's probably fine?
If you really want to remove it, please add a comment in the description for example
Add the implementation for vcore voltage control.
Also remove the reporting of vio18 because it is fixed during DRAM init,
and we won't provide drivers for reading or writing it.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/56106
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I39342aea902a87cdc2c5b862e5d1a889fcc822c5
Gerrit-Change-Number: 56106
Gerrit-PatchSet: 8
Gerrit-Owner: Rex-BC Chen
rex-bc.chen@mediatek.corp-partner.google.com
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Ryan Chuang
ryan.chuang@mediatek.corp-partner.google.com
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Patrick Georgi
pgeorgi@google.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Rex-BC Chen
rex-bc.chen@mediatek.corp-partner.google.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Yu-Ping Wu
yupingso@google.com
Gerrit-Comment-Date: Fri, 09 Jul 2021 02:29:59 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Hung-Te Lin
hungte@chromium.org
Comment-In-Reply-To: Rex-BC Chen
rex-bc.chen@mediatek.corp-partner.google.com
Gerrit-MessageType: comment