Attention is currently required from: Sean Rhodes. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58854 )
Change subject: [WIP] util: Add coreboot Configurator ......................................................................
Patch Set 14:
(364 comments)
File util/coreboot-configurator/LICENSE:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/823a0339_602f230a PS14, Line 5: 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA Do not include the paragraph about writing to the Free Software Foundation's mailing address from the sample GPL notice. The FSF has changed addresses in the past, and may do so again. Linux already includes a copy of the GPL.
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/1dde9fcb_f8b86874 PS14, Line 253: Software Foundation, write to the Free Software Foundation; we sometimes Do not include the paragraph about writing to the Free Software Foundation's mailing address from the sample GPL notice. The FSF has changed addresses in the past, and may do so again. Linux already includes a copy of the GPL.
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/494fa605_e2952ee4 PS14, Line 307: with this program; if not, write to the Free Software Foundation, Inc., Do not include the paragraph about writing to the Free Software Foundation's mailing address from the sample GPL notice. The FSF has changed addresses in the past, and may do so again. Linux already includes a copy of the GPL.
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/5b6f3f23_fe17c248 PS14, Line 308: 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. Do not include the paragraph about writing to the Free Software Foundation's mailing address from the sample GPL notice. The FSF has changed addresses in the past, and may do so again. Linux already includes a copy of the GPL.
File util/coreboot-configurator/contrib/debian/changelog:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/71a86dc1_75c5673b PS14, Line 30: * Added qt5-default dependancy 'dependancy' may be misspelled - perhaps 'dependency'?
File util/coreboot-configurator/src/Documentation.txt:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/58032af2_17b3b77c PS14, Line 5: This allows `coreboot-configurator` to display them in a relavant tab, with a nice 'relavant' may be misspelled - perhaps 'relevant'?
File util/coreboot-configurator/src/application/aboutwindow.h:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/dc2316a5_f421e527 PS14, Line 16: public: spaces required around that ':' (ctx:VxE)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/5e0f417d_31a4dcc3 PS14, Line 17: explicit aboutWindow(QWidget *parent = nullptr); need consistent spacing around '*' (ctx:WxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/87292718_0449d91c PS14, Line 21: Ui::aboutWindow *ui; need consistent spacing around '*' (ctx:WxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/2c17a8ad_751feb85 PS14, Line 21: Ui::aboutWindow *ui; labels should not be indented
File util/coreboot-configurator/src/application/categories.yaml:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/8a90dd6d_9ed72c78 PS14, Line 84: help: Adjust the amout of time before the keyboard backlight turns off when un-used 'amout' may be misspelled - perhaps 'amount'?
File util/coreboot-configurator/src/application/configuration.h:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/fb7c1a12_f8c85ee2 PS14, Line 13: QMap<QString,QString> fromFile(const QString& curr_path); spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/b284f10d_f4d65986 PS14, Line 13: QMap<QString,QString> fromFile(const QString& curr_path); space required after that ',' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/043f11d6_b5860f67 PS14, Line 13: QMap<QString,QString> fromFile(const QString& curr_path); spaces required around that '>' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/73dc1969_e8a5a633 PS14, Line 13: QMap<QString,QString> fromFile(const QString& curr_path); need consistent spacing around '&' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/143178e6_5779a75e PS14, Line 15: QMap<QString,QString> fromNvramTool(); spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/0e539ba1_d381bef5 PS14, Line 15: QMap<QString,QString> fromNvramTool(); space required after that ',' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/dd6ffa3e_d6153933 PS14, Line 15: QMap<QString,QString> fromNvramTool(); spaces required around that '>' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/7929dbed_71db1a0a PS14, Line 17: QMap<QString,QString> mocked(); spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/f1ef8a0f_9abf9b56 PS14, Line 17: QMap<QString,QString> mocked(); space required after that ',' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/9fea4d68_32ed8fb8 PS14, Line 17: QMap<QString,QString> mocked(); spaces required around that '>' (ctx:VxW)
File util/coreboot-configurator/src/application/coreboot_configurator.h:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/161de2be_544f86c1 PS14, Line 29: public: spaces required around that ':' (ctx:VxE)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/7008e030_2694198d PS14, Line 30: coreboot_configurator(QWidget *parent = nullptr); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/851af369_e844d050 PS14, Line 30: coreboot_configurator(QWidget *parent = nullptr); need consistent spacing around '*' (ctx:WxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/c8a20ead_f4ca9752 PS14, Line 37: void showEvent(QShowEvent *ev); need consistent spacing around '*' (ctx:WxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/7da6694f_70074f2e PS14, Line 48: void displaySettings(); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/a1db6b90_fdabed4a PS14, Line 48: void displaySettings(); Bad function definition - void displaySettings() should probably be void displaySettings(void)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/c55634ea_d30ff1a5 PS14, Line 52: void writeToFile(const QString& out_file); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/ccb92cb8_b0647761 PS14, Line 52: void writeToFile(const QString& out_file); need consistent spacing around '&' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/899142c4_6f942351 PS14, Line 55: void updateValue(const QString& name); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/7adc107e_443d17f5 PS14, Line 55: void updateValue(const QString& name); need consistent spacing around '&' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/8a2c9364_fad44dca PS14, Line 59: QString m_fileName; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/56d8b38a_2c980953 PS14, Line 61: QMap<QString, QString> m_values; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/8342959f_7805a956 PS14, Line 61: QMap<QString, QString> m_values; spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/62190311_4269659f PS14, Line 61: QMap<QString, QString> m_values; spaces required around that '>' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/b8837b43_ed84b59c PS14, Line 64: QMap<QString, QVBoxLayout*> m_tabs; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/3241cb70_68e85bae PS14, Line 64: QMap<QString, QVBoxLayout*> m_tabs; spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/e2e8e086_573abcf7 PS14, Line 64: QMap<QString, QVBoxLayout*> m_tabs; spaces required around that '>' (ctx:OxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/2e4b70f5_4baeeb60 PS14, Line 67: YAML::Node m_categories; labels should not be indented
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/5ff63c36_a025c7b5 PS14, Line 70: QComboBox *textToDisplay(const QString &in_string); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/875bd8fd_2cea9a5d PS14, Line 70: QComboBox *textToDisplay(const QString &in_string); need consistent spacing around '&' (ctx:WxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/f3b6917d_5e65cf20 PS14, Line 71: QCheckBox *checkToDisplay(const QString &in_string); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/75bd4ce4_4dab995e PS14, Line 71: QCheckBox *checkToDisplay(const QString &in_string); need consistent spacing around '&' (ctx:WxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/9a5d86e5_f5f784cd PS14, Line 73: Ui::coreboot_configurator *ui; need consistent spacing around '*' (ctx:WxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/b3c38bdd_807f3df4 PS14, Line 73: Ui::coreboot_configurator *ui; labels should not be indented
File util/coreboot-configurator/src/application/coreboot_configurator.cpp:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/d3051d33_ee3f8672 PS14, Line 24: static auto s_errorWindowTitle = "Error Occured"; 'Occured' may be misspelled - perhaps 'Occurred'?
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/3efd0884_1e1249f5 PS14, Line 403: QMessageBox::critical(this, "Error Occured", "Can't open file to write"); 'Occured' may be misspelled - perhaps 'Occurred'?
File util/coreboot-configurator/src/application/qtyaml.h:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/46e95f73_50a9e3f7 PS14, Line 30: template<> spaces required around that '<' (ctx:VxO)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/743d9d71_e13c9ead PS14, Line 30: template<> spaces required around that '>' (ctx:OxE)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/70d2369b_fb8e7a50 PS14, Line 31: struct convert<QString> spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/569da995_8b650f60 PS14, Line 31: struct convert<QString> spaces required around that '>' (ctx:VxE)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/632c0d06_ee1be7b4 PS14, Line 33: static Node encode(const QString& rhs) please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/c2cd97bb_b58a3c5d PS14, Line 33: static Node encode(const QString& rhs) need consistent spacing around '&' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/d6beeb8b_fdc72e0a PS14, Line 33: static Node encode(const QString& rhs) open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/459bc349_55d6feaf PS14, Line 34: { please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/32d367d6_c32c5da6 PS14, Line 35: return Node(rhs.toStdString()); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/6371de5c_81fd80af PS14, Line 35: return Node(rhs.toStdString()); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/4dae5945_d09ec980 PS14, Line 36: } please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/31716a6d_5ace225a PS14, Line 38: static bool decode(const Node& node, QString& rhs) please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/71994a36_e9c7fbd5 PS14, Line 38: static bool decode(const Node& node, QString& rhs) need consistent spacing around '&' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/d81b00aa_99e43d06 PS14, Line 38: static bool decode(const Node& node, QString& rhs) need consistent spacing around '&' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/3c76aead_e8c9f0f4 PS14, Line 38: static bool decode(const Node& node, QString& rhs) open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/fb675d9e_733ec47d PS14, Line 39: { please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/113265cd_36188b6b PS14, Line 40: if (!node.IsScalar()) code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/86e2cfda_e3235001 PS14, Line 40: if (!node.IsScalar()) please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/22f3fedc_550259ec PS14, Line 40: if (!node.IsScalar()) suspect code indent for conditional statements (8, 12)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/16221c8d_467d1149 PS14, Line 41: return false; code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/ab4a637d_868336f4 PS14, Line 41: return false; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/9808b819_498fead4 PS14, Line 42: rhs = QString::fromStdString(node.Scalar()); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/2f2261ba_c5c4b065 PS14, Line 42: rhs = QString::fromStdString(node.Scalar()); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/dbdc50a8_4f69b66c PS14, Line 43: return true; code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/95319f78_e103fd85 PS14, Line 43: return true; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/79f7311d_0b8fe08a PS14, Line 44: } please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/da83dd4a_de8251c9 PS14, Line 48: template<typename Key, typename Value> spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/abbd372f_3304855b PS14, Line 48: template<typename Key, typename Value> spaces required around that '>' (ctx:VxE)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/ca3e81d1_8cb31b8c PS14, Line 49: struct convert<QMap<Key, Value> > spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/dedea6d7_ae7f4cf7 PS14, Line 49: struct convert<QMap<Key, Value> > spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/4653171c_1c59c02f PS14, Line 49: struct convert<QMap<Key, Value> > spaces required around that '>' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/b6d033b6_c9f10d23 PS14, Line 51: static Node encode(const QMap<Key,Value>& rhs) please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/39dce238_02864cd6 PS14, Line 51: static Node encode(const QMap<Key,Value>& rhs) spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/9e212913_50ed517d PS14, Line 51: static Node encode(const QMap<Key,Value>& rhs) space required after that ',' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/10ff5eb6_2ddecb74 PS14, Line 51: static Node encode(const QMap<Key,Value>& rhs) spaces required around that '>' (ctx:VxO)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/a67a0fc3_88663825 PS14, Line 51: static Node encode(const QMap<Key,Value>& rhs) space required before that '&' (ctx:OxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/4de0bb30_0b5f5f9e PS14, Line 51: static Node encode(const QMap<Key,Value>& rhs) space prohibited after that '&' (ctx:OxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/927230f4_0fa2db02 PS14, Line 51: static Node encode(const QMap<Key,Value>& rhs) open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/ccaf29bf_5b3c0a5d PS14, Line 52: { please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/a3522637_ebce85a5 PS14, Line 53: Node node(NodeType::Map); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/bc69d248_f67c925a PS14, Line 53: Node node(NodeType::Map); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/de198ef9_be96d138 PS14, Line 54: auto it = rhs.constBegin(); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/39e4b320_ab4adca8 PS14, Line 54: auto it = rhs.constBegin(); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/51d5d9c3_258c58e2 PS14, Line 55: while (it != rhs.constEnd()) code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/2f5d15b6_971e17fc PS14, Line 55: while (it != rhs.constEnd()) please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/208ec9a4_b381c771 PS14, Line 55: while (it != rhs.constEnd()) that open brace { should be on the previous line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/d53102e2_6a1d1aa7 PS14, Line 55: while (it != rhs.constEnd()) suspect code indent for conditional statements (8, 12)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/ab883f88_d84b3883 PS14, Line 56: { code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/1d3a4c11_a1717656 PS14, Line 56: { please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/c268140c_f6fd187e PS14, Line 57: node.force_insert(it.key(), it.value()); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/11328944_86d34059 PS14, Line 57: node.force_insert(it.key(), it.value()); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/76d1bc85_d1595dbd PS14, Line 58: ++it; code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/f018b8a8_a38caa85 PS14, Line 58: ++it; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/eb33dce8_f9ea0f93 PS14, Line 59: } code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/cbb514af_94a415c0 PS14, Line 59: } please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/0ff12056_10f44744 PS14, Line 60: return node; code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/7ca3f9e9_fe798fed PS14, Line 60: return node; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/8ac319bd_6ac4ac2e PS14, Line 61: } please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/8bf92d01_7d64e2b8 PS14, Line 63: static bool decode(const Node& node, QMap<Key, Value>& rhs) please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/34cdce9c_a6c73515 PS14, Line 63: static bool decode(const Node& node, QMap<Key, Value>& rhs) need consistent spacing around '&' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/c5841bc2_993dbaa9 PS14, Line 63: static bool decode(const Node& node, QMap<Key, Value>& rhs) spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/845315c3_29cf426a PS14, Line 63: static bool decode(const Node& node, QMap<Key, Value>& rhs) spaces required around that '>' (ctx:VxO)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/f0abfa32_ebdb49e4 PS14, Line 63: static bool decode(const Node& node, QMap<Key, Value>& rhs) space required before that '&' (ctx:OxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/65b12d82_9b6889f4 PS14, Line 63: static bool decode(const Node& node, QMap<Key, Value>& rhs) space prohibited after that '&' (ctx:OxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/69dacd55_3518adca PS14, Line 63: static bool decode(const Node& node, QMap<Key, Value>& rhs) open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/a12e8e49_88aea92a PS14, Line 64: { please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/c6bea7a7_a32aaf3f PS14, Line 65: if (!node.IsMap()) code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/a1663e20_a8e2e580 PS14, Line 65: if (!node.IsMap()) please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/555ec78d_54996980 PS14, Line 65: if (!node.IsMap()) suspect code indent for conditional statements (8, 12)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/e003839a_d60f2d3b PS14, Line 66: return false; code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/865953e2_0ffacf9b PS14, Line 66: return false; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/5e5b1ef2_a50174c4 PS14, Line 68: rhs.clear(); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/1d3696f7_cafa9645 PS14, Line 68: rhs.clear(); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/546dbcf4_11034e78 PS14, Line 69: const_iterator it = node.begin(); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/a088dc54_babfd8f5 PS14, Line 69: const_iterator it = node.begin(); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/2c024a53_339659c4 PS14, Line 70: while (it != node.end()) code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/70344a02_adbc890c PS14, Line 70: while (it != node.end()) please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/4ea7abc4_fadd0ea9 PS14, Line 70: while (it != node.end()) that open brace { should be on the previous line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/44b5104f_62187f6c PS14, Line 70: while (it != node.end()) suspect code indent for conditional statements (8, 12)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/4aa9f485_46ecfb30 PS14, Line 71: { code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/1b892a8f_800f570f PS14, Line 71: { please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/bff9b3a8_cfe15e95 PS14, Line 72: rhs[it->first.as<Key>()] = it->second.as<Value>(); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/16625bff_364a1256 PS14, Line 72: rhs[it->first.as<Key>()] = it->second.as<Value>(); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/4eaf9080_6134042a PS14, Line 72: rhs[it->first.as<Key>()] = it->second.as<Value>(); spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/7b8ba0e0_3d0b51b1 PS14, Line 72: rhs[it->first.as<Key>()] = it->second.as<Value>(); spaces required around that '>' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/7e516e86_4bd8f21c PS14, Line 72: rhs[it->first.as<Key>()] = it->second.as<Value>(); spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/808da79a_a0fa11f1 PS14, Line 72: rhs[it->first.as<Key>()] = it->second.as<Value>(); spaces required around that '>' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/94ea0d2e_26270b9c PS14, Line 73: ++it; code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/7d40f6ac_297b6d23 PS14, Line 73: ++it; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/c2bea411_514538c6 PS14, Line 74: } code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/840cf41b_a270dfea PS14, Line 74: } please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/38f11731_8cc1c975 PS14, Line 75: return true; code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/70530452_bdcc749b PS14, Line 75: return true; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/519f455d_e3c75ed6 PS14, Line 76: } please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/52d5cf45_78fb4737 PS14, Line 80: template<typename T> spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/6a0dafc6_c8982ef5 PS14, Line 80: template<typename T> spaces required around that '>' (ctx:VxE)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/1e683573_01958e65 PS14, Line 81: struct convert<QVector<T> > spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/8f8adc64_5b5711f3 PS14, Line 81: struct convert<QVector<T> > spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/ca142fa6_c190fdae PS14, Line 81: struct convert<QVector<T> > spaces required around that '>' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/0be03ad8_59dd8954 PS14, Line 83: static Node encode(const QVector<T>& rhs) please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/dae1a0de_ab0ebd3a PS14, Line 83: static Node encode(const QVector<T>& rhs) spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/2056ca72_72670df6 PS14, Line 83: static Node encode(const QVector<T>& rhs) spaces required around that '>' (ctx:VxO)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/87f6852b_b684b75b PS14, Line 83: static Node encode(const QVector<T>& rhs) space required before that '&' (ctx:OxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/299790af_fca2309d PS14, Line 83: static Node encode(const QVector<T>& rhs) space prohibited after that '&' (ctx:OxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/13cdf361_a51ac32c PS14, Line 83: static Node encode(const QVector<T>& rhs) open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/37d1bf81_629f0e51 PS14, Line 84: { please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/761e3f7a_720d6ee0 PS14, Line 85: Node node(NodeType::Sequence); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/0099c905_bbcadd28 PS14, Line 85: Node node(NodeType::Sequence); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/2238491a_4ff24737 PS14, Line 86: foreach (T value, rhs) { code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/ae0dad7d_dfedfc16 PS14, Line 86: foreach (T value, rhs) { please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/f8ff08a7_0fb1e355 PS14, Line 86: foreach (T value, rhs) { space prohibited between function name and open parenthesis '('
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/dccda299_54d5629b PS14, Line 87: node.push_back(value); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/5aed649a_7c0d6e94 PS14, Line 87: node.push_back(value); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/f81728a6_f7cede06 PS14, Line 88: } code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/b8214330_fcf878bc PS14, Line 88: } please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/6f168572_ca54107a PS14, Line 89: return node; code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/23ab5e60_1543bda8 PS14, Line 89: return node; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/516d6360_59af3f3d PS14, Line 90: } please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/ae425ff2_8e126a9f PS14, Line 92: static bool decode(const Node& node, QVector<T>& rhs) please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/798de0ef_c319444e PS14, Line 92: static bool decode(const Node& node, QVector<T>& rhs) need consistent spacing around '&' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/cfb3c4bf_36704093 PS14, Line 92: static bool decode(const Node& node, QVector<T>& rhs) spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/0bd99270_8c33aa9e PS14, Line 92: static bool decode(const Node& node, QVector<T>& rhs) spaces required around that '>' (ctx:VxO)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/bfa5b22d_26d61d93 PS14, Line 92: static bool decode(const Node& node, QVector<T>& rhs) space required before that '&' (ctx:OxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/1a70ea82_d731355e PS14, Line 92: static bool decode(const Node& node, QVector<T>& rhs) space prohibited after that '&' (ctx:OxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/af9f144d_1bb9d296 PS14, Line 92: static bool decode(const Node& node, QVector<T>& rhs) open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/fbafd070_af44b35e PS14, Line 93: { please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/e9ad286a_a9422809 PS14, Line 94: if (!node.IsSequence()) code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/9932e5c7_d22357ea PS14, Line 94: if (!node.IsSequence()) please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/691164d9_ce01fd82 PS14, Line 94: if (!node.IsSequence()) suspect code indent for conditional statements (8, 12)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/1c90dbf2_053a678e PS14, Line 95: return false; code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/677dde24_21870e9d PS14, Line 95: return false; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/33b28d7a_188e051c PS14, Line 97: rhs.clear(); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/076a71e8_3d33d3b9 PS14, Line 97: rhs.clear(); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/3e104637_9c1f21bb PS14, Line 98: const_iterator it = node.begin(); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/388dd700_1019b1a5 PS14, Line 98: const_iterator it = node.begin(); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/c929afca_190b5777 PS14, Line 99: while (it != node.end()) code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/b0eb4524_c7b46fa8 PS14, Line 99: while (it != node.end()) please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/45182ebd_cf6515c0 PS14, Line 99: while (it != node.end()) that open brace { should be on the previous line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/17802abc_fc206c9f PS14, Line 99: while (it != node.end()) suspect code indent for conditional statements (8, 12)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/d7cd46ee_17215dcb PS14, Line 100: { code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/65580a31_6b035c38 PS14, Line 100: { please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/bf9ed5b0_29700422 PS14, Line 101: rhs.push_back(it->as<T>()); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/821dcb37_90493682 PS14, Line 101: rhs.push_back(it->as<T>()); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/ef0f254b_04cfbcd0 PS14, Line 101: rhs.push_back(it->as<T>()); spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/a3b901bb_c1708ad9 PS14, Line 101: rhs.push_back(it->as<T>()); spaces required around that '>' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/757435b4_2b069a52 PS14, Line 102: ++it; code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/7f5f84fd_7a940bea PS14, Line 102: ++it; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/469a49fe_ec50ce7d PS14, Line 103: } code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/39796d58_163ecac7 PS14, Line 103: } please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/f5950c76_678b06c8 PS14, Line 104: return true; code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/9587b6e0_f8f420b1 PS14, Line 104: return true; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/b94c15f1_11236aa5 PS14, Line 105: } please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/e030a202_bc52a177 PS14, Line 109: template<typename T> spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/6bedbbc6_e229a633 PS14, Line 109: template<typename T> spaces required around that '>' (ctx:VxE)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/236af5f3_5d1eaade PS14, Line 110: struct convert<QList<T> > spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/fcd418cb_72d2dd61 PS14, Line 110: struct convert<QList<T> > spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/c59caa86_dca5c557 PS14, Line 110: struct convert<QList<T> > spaces required around that '>' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/f385d16a_348ae98a PS14, Line 112: static Node encode(const QList<T>& rhs) please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/2bd06e67_44642b19 PS14, Line 112: static Node encode(const QList<T>& rhs) spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/2cbd9bc4_623836cb PS14, Line 112: static Node encode(const QList<T>& rhs) spaces required around that '>' (ctx:VxO)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/3a56d167_0a1ba7a8 PS14, Line 112: static Node encode(const QList<T>& rhs) space required before that '&' (ctx:OxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/dc308874_78e44017 PS14, Line 112: static Node encode(const QList<T>& rhs) space prohibited after that '&' (ctx:OxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/673cec14_69f24bde PS14, Line 112: static Node encode(const QList<T>& rhs) open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/57492a7d_4977c484 PS14, Line 113: { please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/76bd87cd_e550fb60 PS14, Line 114: Node node(NodeType::Sequence); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/6c40c264_8d420a7e PS14, Line 114: Node node(NodeType::Sequence); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/061541b7_15192885 PS14, Line 115: foreach (T value, rhs) { code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/22a4d85d_6b878510 PS14, Line 115: foreach (T value, rhs) { please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/d2109024_84101a29 PS14, Line 115: foreach (T value, rhs) { space prohibited between function name and open parenthesis '('
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/032e080a_c13000b3 PS14, Line 116: node.push_back(value); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/f7f140d8_1970fea0 PS14, Line 116: node.push_back(value); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/15fec8f2_96d4b321 PS14, Line 117: } code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/d824dcf9_262381bb PS14, Line 117: } please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/f5b2e4c7_dc6897aa PS14, Line 118: return node; code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/a06f26ff_4244b4a7 PS14, Line 118: return node; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/e9538384_28aa9c12 PS14, Line 119: } please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/91857909_52e3461b PS14, Line 121: static bool decode(const Node& node, QList<T>& rhs) please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/70473e95_ae4d60ae PS14, Line 121: static bool decode(const Node& node, QList<T>& rhs) need consistent spacing around '&' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/2b071610_e6bb97af PS14, Line 121: static bool decode(const Node& node, QList<T>& rhs) spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/5253d634_d7141cba PS14, Line 121: static bool decode(const Node& node, QList<T>& rhs) spaces required around that '>' (ctx:VxO)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/d7bfca03_4f0cee1a PS14, Line 121: static bool decode(const Node& node, QList<T>& rhs) space required before that '&' (ctx:OxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/3c7d3585_f9ec22d4 PS14, Line 121: static bool decode(const Node& node, QList<T>& rhs) space prohibited after that '&' (ctx:OxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/918e1d65_7fcb1d7c PS14, Line 121: static bool decode(const Node& node, QList<T>& rhs) open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/f8c706e5_afdaa563 PS14, Line 122: { please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/b1801f3f_34763e37 PS14, Line 123: if (!node.IsSequence()) code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/1c3fc22e_fc4280c7 PS14, Line 123: if (!node.IsSequence()) please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/5ec96ec7_c1f00148 PS14, Line 123: if (!node.IsSequence()) suspect code indent for conditional statements (8, 12)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/f10ee6b0_1d648ad3 PS14, Line 124: return false; code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/05c6e200_17950905 PS14, Line 124: return false; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/6d1b9130_232ebd60 PS14, Line 126: rhs.clear(); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/7440f5f8_a3b223cc PS14, Line 126: rhs.clear(); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/67fc0186_73ca8386 PS14, Line 127: const_iterator it = node.begin(); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/332048b8_e680bd6d PS14, Line 127: const_iterator it = node.begin(); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/dfb50ffe_0c03aedc PS14, Line 128: while (it != node.end()) code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/604d44dd_2e61ea6e PS14, Line 128: while (it != node.end()) please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/4231ff19_999ecdb5 PS14, Line 128: while (it != node.end()) that open brace { should be on the previous line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/f485c5a4_30b49dea PS14, Line 128: while (it != node.end()) suspect code indent for conditional statements (8, 12)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/2d169ad5_3a992656 PS14, Line 129: { code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/835af2e9_6c477d5f PS14, Line 129: { please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/db0f8d21_765703d8 PS14, Line 130: rhs.push_back(it->as<T>()); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/550fa932_1ca40d05 PS14, Line 130: rhs.push_back(it->as<T>()); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/33186e99_6d965493 PS14, Line 130: rhs.push_back(it->as<T>()); spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/2219b411_2272a0a3 PS14, Line 130: rhs.push_back(it->as<T>()); spaces required around that '>' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/acf1947e_24c7e13f PS14, Line 131: ++it; code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/20b7cdb4_690d4b54 PS14, Line 131: ++it; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/528b1a3d_c9ee8dee PS14, Line 132: } code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/798d3fb3_1e76fabd PS14, Line 132: } please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/019c96ce_49e64e1e PS14, Line 133: return true; code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/5dcdefaa_2e65c782 PS14, Line 133: return true; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/28a5c9fe_c43fd458 PS14, Line 134: } please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/6a0851d8_2bad2940 PS14, Line 138: template<typename T, typename U> spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/3ea999f1_b6f1c439 PS14, Line 138: template<typename T, typename U> spaces required around that '>' (ctx:VxE)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/e4c20bbc_0dd92bdd PS14, Line 139: struct convert<QPair<T,U> > spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/fe400f5c_97b7077b PS14, Line 139: struct convert<QPair<T,U> > spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/fe868618_49162f0e PS14, Line 139: struct convert<QPair<T,U> > space required after that ',' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/ba90b91c_af92b6a7 PS14, Line 139: struct convert<QPair<T,U> > spaces required around that '>' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/aca36ffe_a6e8350e PS14, Line 141: static Node encode(const QPair<T,U>& rhs) please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/1c280b61_b24ea828 PS14, Line 141: static Node encode(const QPair<T,U>& rhs) spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/342513fc_920802d8 PS14, Line 141: static Node encode(const QPair<T,U>& rhs) space required after that ',' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/15e7caaf_1270359d PS14, Line 141: static Node encode(const QPair<T,U>& rhs) spaces required around that '>' (ctx:VxO)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/6bbcdc79_4153de46 PS14, Line 141: static Node encode(const QPair<T,U>& rhs) space required before that '&' (ctx:OxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/b59c2ec1_ee43125b PS14, Line 141: static Node encode(const QPair<T,U>& rhs) space prohibited after that '&' (ctx:OxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/2454ab19_9586eea0 PS14, Line 141: static Node encode(const QPair<T,U>& rhs) open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/f810c9b3_29cbc111 PS14, Line 142: { please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/d7351648_98445356 PS14, Line 143: Node node(NodeType::Sequence); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/b51a609c_c3d4e6bb PS14, Line 143: Node node(NodeType::Sequence); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/6bbcf7db_3fef961f PS14, Line 144: node.push_back(rhs.first); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/76c0c87a_55341f74 PS14, Line 144: node.push_back(rhs.first); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/780897cf_1170b205 PS14, Line 145: node.push_back(rhs.second); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/6d4f0fb6_4e212cbb PS14, Line 145: node.push_back(rhs.second); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/cb1150d5_c2fa8055 PS14, Line 146: return node; code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/1ae74b3f_26220807 PS14, Line 146: return node; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/8c097918_38f90a52 PS14, Line 147: } please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/2c1adbc7_f757bf8c PS14, Line 149: static bool decode(const Node& node, QPair<T,U>& rhs) please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/b2bb9066_7a731bf4 PS14, Line 149: static bool decode(const Node& node, QPair<T,U>& rhs) need consistent spacing around '&' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/45cc801d_819cc97f PS14, Line 149: static bool decode(const Node& node, QPair<T,U>& rhs) spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/0b151220_15e1ba15 PS14, Line 149: static bool decode(const Node& node, QPair<T,U>& rhs) space required after that ',' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/2a0c51b5_23e71532 PS14, Line 149: static bool decode(const Node& node, QPair<T,U>& rhs) spaces required around that '>' (ctx:VxO)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/4af1dd28_71a0285a PS14, Line 149: static bool decode(const Node& node, QPair<T,U>& rhs) space required before that '&' (ctx:OxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/27ceb454_b353f0c3 PS14, Line 149: static bool decode(const Node& node, QPair<T,U>& rhs) space prohibited after that '&' (ctx:OxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/ddc4cc6a_df580260 PS14, Line 149: static bool decode(const Node& node, QPair<T,U>& rhs) open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/59418e2d_9b139fe5 PS14, Line 150: { please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/812e3649_f5fd28cf PS14, Line 151: if (!node.IsSequence()) code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/5de6f3e4_2bd15765 PS14, Line 151: if (!node.IsSequence()) please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/1c4bb431_3ae72a9a PS14, Line 151: if (!node.IsSequence()) suspect code indent for conditional statements (8, 12)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/a5ac5d6b_e0caf53f PS14, Line 152: return false; code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/1741975b_61ffa32e PS14, Line 152: return false; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/d30da64b_5614468d PS14, Line 153: if (node.size() != 2) code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/74746ee1_778b11f1 PS14, Line 153: if (node.size() != 2) please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/6bbd644d_582b49cf PS14, Line 153: if (node.size() != 2) suspect code indent for conditional statements (8, 12)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/fa51509b_5811d4f9 PS14, Line 154: return false; code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/181061da_952d3d52 PS14, Line 154: return false; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/6e02b8f8_d9874cd8 PS14, Line 156: rhs.first = node[0].as<T>(); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/20eafcee_3e2fe912 PS14, Line 156: rhs.first = node[0].as<T>(); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/d7af8c77_3a6b2d20 PS14, Line 156: rhs.first = node[0].as<T>(); spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/de2353b1_61708281 PS14, Line 156: rhs.first = node[0].as<T>(); spaces required around that '>' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/566372ac_b918ad5d PS14, Line 157: rhs.second = node[1].as<U>(); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/2df8ca1c_5bd861b6 PS14, Line 157: rhs.second = node[1].as<U>(); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/2e269a4b_9696fad9 PS14, Line 157: rhs.second = node[1].as<U>(); spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/c4b76cbe_647b4936 PS14, Line 157: rhs.second = node[1].as<U>(); spaces required around that '>' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/49505fed_97441730 PS14, Line 158: return true; code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/cf75d0a0_2bebc600 PS14, Line 158: return true; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/27bd3312_a66636da PS14, Line 159: } please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/2210a4f4_ca343d95 PS14, Line 163: template<> spaces required around that '<' (ctx:VxO)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/af048623_381f549b PS14, Line 163: template<> spaces required around that '>' (ctx:OxE)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/d86ae31b_0d1f3c89 PS14, Line 164: struct convert<QStringList> spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/ef3396e8_e877d2a0 PS14, Line 164: struct convert<QStringList> spaces required around that '>' (ctx:VxE)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/cf60aad3_35dfe2a9 PS14, Line 166: static Node encode(const QStringList& rhs) please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/2be4b7da_289d23f5 PS14, Line 166: static Node encode(const QStringList& rhs) need consistent spacing around '&' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/e767e6ac_9cafc83f PS14, Line 166: static Node encode(const QStringList& rhs) open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/8ba1301f_963b09e3 PS14, Line 167: { please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/6cab14b3_74d83e00 PS14, Line 168: Node node(NodeType::Sequence); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/ed635923_6993366a PS14, Line 168: Node node(NodeType::Sequence); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/22e730ab_3772955d PS14, Line 169: for (const auto &value: rhs) { code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/3d564f8f_9a2e0294 PS14, Line 169: for (const auto &value: rhs) { please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/c4a07297_d9484f51 PS14, Line 169: for (const auto &value: rhs) { suspect code indent for conditional statements (8, 12)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/5bf85a50_c8bfc8e9 PS14, Line 169: for (const auto &value: rhs) { need consistent spacing around '&' (ctx:WxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/085dfada_f9e555fb PS14, Line 169: for (const auto &value: rhs) { spaces required around that ':' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/f9da089a_c70ceb5e PS14, Line 169: for (const auto &value: rhs) { braces {} are not necessary for single statement blocks
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/4f7d53bc_2bfa8632 PS14, Line 170: node.push_back(value); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/1cebe43b_aef62e9c PS14, Line 170: node.push_back(value); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/1b392aa6_56ec12f0 PS14, Line 171: } code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/3d9f60f3_5d3725d6 PS14, Line 171: } please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/e8539580_ac34bfaa PS14, Line 172: return node; code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/c093669a_bd11b6e3 PS14, Line 172: return node; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/3d5659ff_6d2bdcc3 PS14, Line 173: } please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/93910a1d_ebb0e06b PS14, Line 175: static bool decode(const Node& node, QStringList& rhs) please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/5e03a72a_20d6cb7f PS14, Line 175: static bool decode(const Node& node, QStringList& rhs) need consistent spacing around '&' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/8ed4f5aa_70a08a53 PS14, Line 175: static bool decode(const Node& node, QStringList& rhs) need consistent spacing around '&' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/51be5b26_a1c3d375 PS14, Line 175: static bool decode(const Node& node, QStringList& rhs) open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/74f8ea18_6b38e1c2 PS14, Line 176: { please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/ee22116c_95d09f1f PS14, Line 177: if (!node.IsSequence()) code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/b633d512_2dde4de8 PS14, Line 177: if (!node.IsSequence()) please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/450b9f14_dfb3f39e PS14, Line 177: if (!node.IsSequence()) suspect code indent for conditional statements (8, 12)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/d40a7786_491de33e PS14, Line 178: return false; code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/13b6752c_9bebc98f PS14, Line 178: return false; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/29262a13_92cbaf5e PS14, Line 180: rhs.clear(); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/cf2bd553_22703273 PS14, Line 180: rhs.clear(); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/db6e2564_be9c758c PS14, Line 181: const_iterator it = node.begin(); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/a17265fc_66ef24a5 PS14, Line 181: const_iterator it = node.begin(); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/69074754_277cff72 PS14, Line 182: while (it != node.end()) code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/39be6267_a2f7a73b PS14, Line 182: while (it != node.end()) please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/d358eb8c_b9afcf3f PS14, Line 182: while (it != node.end()) that open brace { should be on the previous line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/3b3a5e35_31764d6e PS14, Line 182: while (it != node.end()) suspect code indent for conditional statements (8, 12)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/8b66df9a_f59448c2 PS14, Line 183: { code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/be04960a_a23e31b5 PS14, Line 183: { please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/8ce537bf_990f0a60 PS14, Line 184: rhs.push_back(it->as<QString>()); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/786845a9_7195f291 PS14, Line 184: rhs.push_back(it->as<QString>()); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/945339af_e0956273 PS14, Line 184: rhs.push_back(it->as<QString>()); spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/8c50b1a3_48d81214 PS14, Line 184: rhs.push_back(it->as<QString>()); spaces required around that '>' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/f55214ab_6e5e68eb PS14, Line 185: ++it; code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/494b2aed_a54d8936 PS14, Line 185: ++it; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/7ecf7849_df60cec2 PS14, Line 186: } code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/ab325b7a_4fdd1b04 PS14, Line 186: } please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/b3983596_7f5f005d PS14, Line 187: return true; code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/4e2bdedb_6ceeabed PS14, Line 187: return true; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132309): https://review.coreboot.org/c/coreboot/+/58854/comment/8bb6eb38_133d0663 PS14, Line 188: } please, no spaces at the start of a line