Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43577 )
Change subject: libpayload: Cache physical location of serial-console struct
......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/43577/2/payloads/libpayload/drivers...
File payloads/libpayload/drivers/serial/ipq40xx.c:
https://review.coreboot.org/c/coreboot/+/43577/2/payloads/libpayload/drivers...
PS2, Line 556: !lib_sysinfo.cb_serial
Shouldn't this be `phys_to_virt(lib_sysinfo.cb_serial)` instead? ipq40xx and ipq806x do not agree
--
To view, visit
https://review.coreboot.org/c/coreboot/+/43577
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Icd30e95c6b8115d16dd793914fb01a1a9da1854f
Gerrit-Change-Number: 43577
Gerrit-PatchSet: 2
Gerrit-Owner: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Felix Singer
felixsinger@posteo.net
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Tue, 04 Aug 2020 21:56:58 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment