Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37210 )
Change subject: [WIP] soc/amd/common: Remove guards on ACPIMMIO utils ......................................................................
Patch Set 1:
(1 comment)
Patch Set 1:
(1 comment)
What would happen if there was a new SOC that did not supported one of these MMIO? Or if it supported a different one? I agree that apparently Picasso and Stoney Ridge support the same set... but the guards where established for this situation and I'm not sure if it's wise to remove them.
The comments already say that for each bank, it is not guaranteed register definitions remain the same across platform generations. So developer needs to go through these individually anyways and verify what banks are implemented.
Anyways, I have a plan to mask the set of banks per platform, but it will not address the above statement about incompatible banks located at same address.
https://review.coreboot.org/c/coreboot/+/37210/1/src/soc/amd/common/block/in... File src/soc/amd/common/block/include/amdblocks/gpio_banks.h:
https://review.coreboot.org/c/coreboot/+/37210/1/src/soc/amd/common/block/in... PS1, Line 21: acpimmio_map
Why the need for this, being that nothing was added to this header? I can see it's wide spread, but […]
ACPIMMIO_GPIOx in this file. There was indirect includes.