[coreboot-gerrit] Change in coreboot[master]: mb/google/hatch/variants/hatch: Set PCH Thermal Threshold value to 77...

[Sumeet R Pawnikar (Code Review)]

Sumeet R Pawnikar has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33147 )

Change subject: mb/google/hatch/variants/hatch: Set PCH Thermal Threshold value to 77 deg C
......................................................................

Patch Set 7:

(2 comments)

https://review.coreboot.org/c/coreboot/+/33147/3/src/mainboard/google/hatch/... 
File src/mainboard/google/hatch/variants/baseboard/devicetree.cb:

https://review.coreboot.org/c/coreboot/+/33147/3/src/mainboard/google/hatch/... 
PS3, Line 191: on
> For bootblock we use tempbar and that does end up adding device specific code to program the BARs. […]

Done

https://review.coreboot.org/c/coreboot/+/33147/4/src/mainboard/google/hatch/... 
File src/mainboard/google/hatch/variants/hatch/overridetree.cb:

https://review.coreboot.org/c/coreboot/+/33147/4/src/mainboard/google/hatch/... 
PS4, Line 57: .pch_thermal_trip = 77,
> Shouldn't this be part of baseboard since it applies to all Hatch variants?

Thanks for this input. This is addressed in patch set 7.