Mike Banon has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33777 ) Change subject: asus/am1i-a: remove unnecessary VGA_BIOS_ID default ...................................................................... Patch Set 5: (2 comments) https://review.coreboot.org/c/coreboot/+/33777/1//COMMIT_MSG Commit Message: https://review.coreboot.org/c/coreboot/+/33777/1//COMMIT_MSG@7 PS1, Line 7: set VGA_BIOS_ID to 1002,9830 instead of default 1002,9836
No need to mention the IDs here Resolved.
https://review.coreboot.org/c/coreboot/+/33777/1/src/mainboard/asus/am1i-a/K... File src/mainboard/asus/am1i-a/Kconfig: https://review.coreboot.org/c/coreboot/+/33777/1/src/mainboard/asus/am1i-a/K... PS1, Line 47: default "1002,9830"
True, there is no need to replace it here. Resolved
-- To view, visit https://review.coreboot.org/c/coreboot/+/33777 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I75c815b13934afcb5be316f85933f7c200d55bbd Gerrit-Change-Number: 33777 Gerrit-PatchSet: 5 Gerrit-Owner: Mike Banon <mikebdp2@gmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com> Gerrit-Reviewer: Mike Banon <mikebdp2@gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-CC: Paul Menzel <paulepanter@users.sourceforge.net> Gerrit-Comment-Date: Sun, 20 Oct 2019 09:17:34 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: HAOUAS Elyes <ehaouas@noos.fr> Comment-In-Reply-To: Angel Pons <th3fanbus@gmail.com> Gerrit-MessageType: comment