Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35726 )
Change subject: drivers/aspeed/common: Add support for high resolution framebuffer ......................................................................
Patch Set 6: Code-Review+1
(7 comments)
https://review.coreboot.org/c/coreboot/+/35726/6/src/drivers/aspeed/common/a... File src/drivers/aspeed/common/ast_i2c.c:
https://review.coreboot.org/c/coreboot/+/35726/6/src/drivers/aspeed/common/a... PS6, Line 30: * Authors: Dave Airlie airlied@redhat.com why not just put these two lines below the copyright above?
https://review.coreboot.org/c/coreboot/+/35726/6/src/drivers/aspeed/common/a... PS6, Line 32: */ : #include nit: newline before include
https://review.coreboot.org/c/coreboot/+/35726/6/src/drivers/aspeed/common/a... File src/drivers/aspeed/common/ast_mode.c:
https://review.coreboot.org/c/coreboot/+/35726/6/src/drivers/aspeed/common/a... PS6, Line 29: /* : * Authors: Dave Airlie airlied@redhat.com : * Authors: 9Elements Agency GmbH patrick.rudolph@9elements.com move up below copyright?
https://review.coreboot.org/c/coreboot/+/35726/6/src/drivers/aspeed/common/a... PS6, Line 34: */ : #include newline after comment
https://review.coreboot.org/c/coreboot/+/35726/6/src/drivers/aspeed/common/a... PS6, Line 37: why two newlines?
https://review.coreboot.org/c/coreboot/+/35726/6/src/drivers/aspeed/common/a... File src/drivers/aspeed/common/ast_mode_corebootfb.c:
https://review.coreboot.org/c/coreboot/+/35726/6/src/drivers/aspeed/common/a... PS6, Line 28: */ : /* : * Authors: Dave Airlie airlied@redhat.com : * Authors: 9Elements Agency GmbH patrick.rudolph@9elements.com move below Copyright?
https://review.coreboot.org/c/coreboot/+/35726/6/src/drivers/aspeed/common/a... PS6, Line 32: */ newline