Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37618 )
Change subject: amd/bettong: Enable SATA controller ......................................................................
Patch Set 1:
(3 comments)
https://review.coreboot.org/c/coreboot/+/37618/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/37618/1//COMMIT_MSG@9 PS1, Line 9: the SATA controller is enabled on FCH reset So it worked before, or not?
Did the original porters only test with IDE stuff and not S-ATA/AHCI?
https://review.coreboot.org/c/coreboot/+/37618/1/src/mainboard/amd/bettong/B... File src/mainboard/amd/bettong/BiosCallOuts.c:
https://review.coreboot.org/c/coreboot/+/37618/1/src/mainboard/amd/bettong/B... PS1, Line 63: /* Enable IMC fan control. the recommended way */ Such unrelated fixes need to go in a separate commit.
https://review.coreboot.org/c/coreboot/+/37618/1/src/mainboard/amd/bettong/B... PS1, Line 93: Please remove the blank line.