Marshall Dawson has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36418 )
Change subject: cpu/x86: Introduce .near_reset_vector
......................................................................
Patch Set 5:
(1 comment)
I have started CB:37895 as an approach to drop static C_ENV_BOOTBLOCK_SIZE and align the required x86 realmode/assembly parts towards the end of the bootblock.
OK, will spend some time reviewing that.
https://review.coreboot.org/c/coreboot/+/36418/3/src/cpu/x86/16bit/reset16.l...
File src/cpu/x86/16bit/reset16.ld:
https://review.coreboot.org/c/coreboot/+/36418/3/src/cpu/x86/16bit/reset16.l...
PS3, Line 29: #endif
I'll have a look at APL and intel/d945gcfl then.
Ack
--
To view, visit
https://review.coreboot.org/c/coreboot/+/36418
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I6e7888c778e1d1cc426e4160543f4a4662ebf834
Gerrit-Change-Number: 36418
Gerrit-PatchSet: 5
Gerrit-Owner: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Aaron Durbin
adurbin@chromium.org
Gerrit-CC: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Mon, 06 Jan 2020 23:52:21 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Kyösti Mälkki
kyosti.malkki@gmail.com
Comment-In-Reply-To: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-MessageType: comment