Attention is currently required from: Lance Zhao, Tim Wawrzynczak.
Kapil Porwal has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/70022 )
Change subject: acpi: Create a common method to add DmaProperty
......................................................................
Patch Set 2:
(2 comments)
File src/acpi/device.c:
https://review.coreboot.org/c/coreboot/+/70022/comment/10502348_a9ce83c1
PS1, Line 1194: if (prev_dsd == NULL) {
braces {} are not necessary for single statement blocks […]
Ack
https://review.coreboot.org/c/coreboot/+/70022/comment/bc58caba_886bf2a7
PS1, Line 1200: if (prev_dsd == NULL) {
braces {} are not necessary for single statement blocks […]
Ack
--
To view, visit
https://review.coreboot.org/c/coreboot/+/70022
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I75b3f22ad29f90f3c3b251bd0d70bae9d75f71fe
Gerrit-Change-Number: 70022
Gerrit-PatchSet: 2
Gerrit-Owner: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Lance Zhao
Gerrit-Reviewer: Tim Wawrzynczak
inforichland@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Lance Zhao
Gerrit-Attention: Tim Wawrzynczak
inforichland@gmail.com
Gerrit-Comment-Date: Sat, 26 Nov 2022 13:49:53 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Kapil Porwal
kapilporwal@google.com
Gerrit-MessageType: comment