Attention is currently required from: Avi Uday, Jayvik Desai, Kapil Porwal, Pranava Y N, Subrata Banik.
Paul Menzel has posted comments on this change by Subrata Banik. ( https://review.coreboot.org/c/coreboot/+/87462?usp=email )
Change subject: mainboard/google/fatcat: Conditional ALC256 HDA init for fatcat variant
......................................................................
Patch Set 2: Code-Review+1
(3 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/87462/comment/a08fde0d_d7b9938a?usp... :
PS2, Line 7: mainboard/google/fatcat: Conditional ALC256 HDA init for fatcat variant
Make it a statement:
mb/google/fatcat/var/fatcat: Conditionally init ALC256 HDA
https://review.coreboot.org/c/coreboot/+/87462/comment/1c29aaec_77732f69?usp... :
PS2, Line 23: which
Would fit on line above.
https://review.coreboot.org/c/coreboot/+/87462/comment/24b6c228_ef35ab68?usp... :
PS2, Line 27: were
are
--
To view, visit
https://review.coreboot.org/c/coreboot/+/87462?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ifc158b7d15c763cc07d28154259b7e64709bea16
Gerrit-Change-Number: 87462
Gerrit-PatchSet: 2
Gerrit-Owner: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Avi Uday
aviuday@google.com
Gerrit-Reviewer: Jayvik Desai
jayvik@google.com
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Paul Menzel
paulepanter@mailbox.org
Gerrit-Reviewer: Pranava Y N
pranavayn@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Jayvik Desai
jayvik@google.com
Gerrit-Attention: Avi Uday
aviuday@google.com
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Kapil Porwal
kapilporwal@google.com
Gerrit-Attention: Pranava Y N
pranavayn@google.com
Gerrit-Comment-Date: Sat, 26 Apr 2025 20:21:02 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes