[coreboot-gerrit] Change in coreboot[master]: [WIP] intel/skylake: Refactor IRQ assignments

[Kyösti Mälkki (Code Review)]

Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35735 )

Change subject: [WIP] intel/skylake: Refactor IRQ assignments
......................................................................

Patch Set 1:

(2 comments)

https://review.coreboot.org/c/coreboot/+/35735/1/src/soc/intel/skylake/irq.c 
File src/soc/intel/skylake/irq.c:

https://review.coreboot.org/c/coreboot/+/35735/1/src/soc/intel/skylake/irq.c... 
PS1, Line 192: 		sizeof(SI_PCH_DEVICE_INTERRUPT_CONFIG));
> I wasn't looking that closely. Sorry. […]

Well I won't fix this. Subrata?

https://review.coreboot.org/c/coreboot/+/35735/1/src/soc/intel/skylake/irq.c... 
PS1, Line 212: 	memcpy(params->PxRcConfig, irq_config, PCH_MAX_IRQ_CONFIG);
> Correct. Static analysis tools will totally catch it as well as the compiler. […]

Ack