Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39237 )
Change subject: mb/google/dedede: Add SD card support
......................................................................
Patch Set 28: Code-Review+2
(1 comment)
https://review.coreboot.org/c/coreboot/+/39237/23/src/mainboard/google/deded...
File src/mainboard/google/dedede/variants/baseboard/gpio.c:
https://review.coreboot.org/c/coreboot/+/39237/23/src/mainboard/google/deded...
PS23, Line 284: GPP_G7
I checked for the below errors: […]
Thanks Aamir! I still don't understand why the WP creates problems only at init time. Probably transient state? We don't need to block this change, but it would be good to understand the dependency/recommendation on how the SD WP should be configured when unused.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/39237
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I90c8ceb85ada23718ff7b6fd7013317c818dd532
Gerrit-Change-Number: 39237
Gerrit-PatchSet: 28
Gerrit-Owner: Varshit B Pandya
varshit.b.pandya@intel.com
Gerrit-Reviewer: Aamir Bohra
aamir.bohra@intel.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-CC: Ian Feng
ian_feng@compal.corp-partner.google.com
Gerrit-CC: Patrick Georgi
pgeorgi@google.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Thu, 28 May 2020 20:40:51 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Furquan Shaikh
furquan@google.com
Comment-In-Reply-To: Aamir Bohra
aamir.bohra@intel.com
Gerrit-MessageType: comment