Hello build bot (Jenkins), Patrick Georgi, Frans Hendriks, Tristan Corrick, Angel Pons, Andrey Petrov, Patrick Rudolph, Piotr Król, David Guckian, Michał Żygowski, Damien Zammit, Martin Roth, Lee Leahy, Christian Walter, Vanessa Eusebio, Huang Jin, Alexander Couzens, Werner Zeh, Evgeny Zinoviev, Wim Vervoorn, Felix Held,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/40930
to look at the new patch set (#6).
Change subject: acpi: Move ACPI table support out of arch/x86 (1/5) ......................................................................
acpi: Move ACPI table support out of arch/x86 (1/5)
This change moves all ACPI table support in coreboot currently living under arch/x86 into common code to make it architecture independent. ACPI table generation is not really tied to any architecture and hence it makes sense to move this to its own directory.
In order to make it easier to review, this change is being split into multiple CLs. This is change 1/5 which moves .c files from arch/x86 to acpi/.
The only acpi files that are still retained under arch/x86 are: a. acpi_s3.c: This doesn't really deal with ACPI tables. Also, there are some assumptions in there about SMM which will have to be resolved if this file needs to be moved to common code.
b. acpi_bert_storage.c/bert_storage.h: This file is currently written specifically with x86 in mind. So, not moving the file for now.
Motivation for this change: Not all stages on Picasso SoC are targeted for the same architecture. For example, verstage (if runs before bootblock) will be targeted for non-x86. This makes it difficult to add device tree to verstage which would be required to get to SoC configs from the tree. This is because the device tree on x86 platforms currently contains a lot of devices that require ACPI related enums and structs (like acpi_gpio, acpi_pld, acpi_dp and so on). Hence, this change removes all ACPI table support out of arch/x86.
BUG=b:155428745
Change-Id: Icc6b793c52c86483a8c52e0555619e36869a869e Signed-off-by: Furquan Shaikh furquan@google.com --- M src/acpi/Makefile.inc R src/acpi/acpi.c R src/acpi/acpi_device.c R src/acpi/acpi_pld.c R src/acpi/acpigen.c R src/acpi/acpigen_dsm.c R src/acpi/acpigen_ps2_keybd.c M src/arch/x86/Makefile.inc 8 files changed, 12 insertions(+), 7 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/30/40930/6