30 May
2019
30 May
'19
11:46 a.m.
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33115 )
Change subject: Makefile.inc: Exclude smm related files from ramstage compilation ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/#/c/33115/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/#/c/33115/1//COMMIT_MSG@7 PS1, Line 7: Makefile.inc: Exclude smm related files from ramstage compilation
smm build targets are only pulled in when there's a high level dependency that is requesting smm. […]
So looks like we might need to dedicated config for smm, which doesn't exist today.
--
To view, visit https://review.coreboot.org/c/coreboot/+/33115
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I17a3eb80a4d5ef86e0319357c01b6bf5b90ef15b
Gerrit-Change-Number: 33115
Gerrit-PatchSet: 1
Gerrit-Owner: Subrata Banik subrata.banik@intel.com
Gerrit-Reviewer: Furquan Shaikh furquan@google.com
Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com
Gerrit-Reviewer: Subrata Banik subrata.banik@intel.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Reviewer: ron minnich rminnich@gmail.com
Gerrit-CC: Aaron Durbin adurbin@chromium.org
Gerrit-Comment-Date: Thu, 30 May 2019 14:46:46 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Aaron Durbin adurbin@chromium.org
Comment-In-Reply-To: Subrata Banik subrata.banik@intel.com
Gerrit-MessageType: comment