Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38814 )
Change subject: soc/intel/apl: disable NPK device in devicetree.cb
......................................................................
Patch Set 13: Code-Review+2
(1 comment)
https://review.coreboot.org/c/coreboot/+/38814/13/src/soc/intel/apollolake/r...
File src/soc/intel/apollolake/romstage.c:
https://review.coreboot.org/c/coreboot/+/38814/13/src/soc/intel/apollolake/r...
PS13, Line 295: #if CONFIG(SOC_INTEL_GLK)
Can C if statement be used?
Presumably not since field names are different between the 2 headers.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/38814
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I910245d4ff35a6a0a9059fb6911d4426cdb999b6
Gerrit-Change-Number: 38814
Gerrit-PatchSet: 13
Gerrit-Owner: Maxim Polyakov
max.senia.poliak@gmail.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Maxim Polyakov
max.senia.poliak@gmail.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Subrata Banik
subrata.banik@intel.com
Gerrit-Comment-Date: Fri, 28 Feb 2020 16:44:43 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-MessageType: comment