Patrick Rudolph has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/47708 )
Change subject: cpu/x86/sipi_vector: Only run microcode update on Intel CPUs ......................................................................
cpu/x86/sipi_vector: Only run microcode update on Intel CPUs
AMD CPUs do not update the microcode as part of the AP bringup. Only run microcode updates on Intel. This will reduce the size of the sipi vector on AMD CPUs.
Change-Id: Ifb750c62ad80283ad4b486f9f8533ef41497084f Signed-off-by: Patrick Rudolph patrick.rudolph@9elements.com --- M src/cpu/x86/sipi_vector_c_handler.c 1 file changed, 6 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/08/47708/1
diff --git a/src/cpu/x86/sipi_vector_c_handler.c b/src/cpu/x86/sipi_vector_c_handler.c index 4d06535..fa11748 100644 --- a/src/cpu/x86/sipi_vector_c_handler.c +++ b/src/cpu/x86/sipi_vector_c_handler.c @@ -103,7 +103,12 @@ */ asmlinkage void sipi_secondary_early_entry(struct sipi_params *const params, int cpu_num) { - sipi_update_microcode(params); + /* + * For Intel CPUs refer to Intel SDM: + * Chapter 8.4.4.2 Typical AP Initialization Sequence + */ + if (cpu_is_intel()) + sipi_update_microcode(params); sipi_set_mtrrs(params); sipi_enable_caches(params); sipi_enable_sse(params);