Attention is currently required from: Felix Singer, Matt DeVillier.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79311?usp=email )
The change is no longer submittable: All-Comments-Resolved is unsatisfied now.
Change subject: mb/google/galdos/var/lars: Implement touchscreen power sequencing
......................................................................
Patch Set 1:
(1 comment)
File src/mainboard/google/glados/variants/lars/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/79311/comment/e321c16f_c5e34f06 :
PS1, Line 23: register "reset_delay_ms" = "20"
What is the source for the timing values?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/79311?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I49ccb29ec4589315a4abe3c0ea8fa76f97080bcd
Gerrit-Change-Number: 79311
Gerrit-PatchSet: 1
Gerrit-Owner: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Reviewer: Eric Lai
ericllai@google.com
Gerrit-Reviewer: Felix Singer
service+coreboot-gerrit@felixsinger.de
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Felix Singer
service+coreboot-gerrit@felixsinger.de
Gerrit-Attention: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Comment-Date: Wed, 29 Nov 2023 09:40:22 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment