build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31997 )
Change subject: src/arch: An upgrade of SMBIOS to latest version 3.2
......................................................................
Patch Set 3:
(3 comments)
https://review.coreboot.org/#/c/31997/3/src/arch/x86/smbios.c
File src/arch/x86/smbios.c:
https://review.coreboot.org/#/c/31997/3/src/arch/x86/smbios.c@569
PS3, Line 569: if ((cpuid_eax(0) < 0xb) || !(leaf_b.eax | leaf_b.ebx | leaf_b.ecx | leaf_b.edx))
line over 80 characters
https://review.coreboot.org/#/c/31997/3/src/arch/x86/smbios.c@605
PS3, Line 605: u16 core_count = smbios_processor_core_or_thread_count(PROCESSOR_INFO_CORE_COUNT_TYPE);
line over 80 characters
https://review.coreboot.org/#/c/31997/3/src/arch/x86/smbios.c@606
PS3, Line 606: u16 thread_count = smbios_processor_core_or_thread_count(PROCESSOR_INFO_THREAD_COUNT_TYPE);
line over 80 characters
--
To view, visit
https://review.coreboot.org/c/coreboot/+/31997
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iab98e063874c9738e48a387cd91341d266391156
Gerrit-Change-Number: 31997
Gerrit-PatchSet: 3
Gerrit-Owner: Francois Toguo Fotso
francois.toguo.fotso@intel.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Francois Toguo Fotso
francois.toguo.fotso@intel.com
Gerrit-Reviewer: Lijian Zhao
lijian.zhao@intel.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Richard Spiegel
richard.spiegel@silverbackltd.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Francois Toguo Fotso
francois.toguo.fotso@intel.corp-partner.google.com
Gerrit-Comment-Date: Wed, 20 Mar 2019 23:51:02 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment