Nick Vaccaro has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45946 )
Change subject: mb/google/volteer: disable TBT if no USB4 hardware available
......................................................................
Patch Set 10:
(1 comment)
https://review.coreboot.org/c/coreboot/+/45946/9/src/mainboard/google/voltee...
File src/mainboard/google/volteer/mainboard.c:
https://review.coreboot.org/c/coreboot/+/45946/9/src/mainboard/google/voltee...
PS9, Line 92: ITbtPcieRootPortEn
I wonder if you could just memset this whole array to 0? or is the dev check important?
Good suggestion. Given this logic never set it to 1, only to 0, whether or not dev is enabled isn't really important here (original logic in soc set to 1 or 0, so it was important that it made sure dev was active before setting to 1, but the new logic doesn't need it).
--
To view, visit
https://review.coreboot.org/c/coreboot/+/45946
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iab23c07e15f754ca807f128b9edad7fdc9a44b9d
Gerrit-Change-Number: 45946
Gerrit-PatchSet: 10
Gerrit-Owner: Nick Vaccaro
nvaccaro@google.com
Gerrit-Reviewer: Derek Huang
derek.huang@intel.corp-partner.google.com
Gerrit-Reviewer: Duncan Laurie
dlaurie@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Tue, 06 Oct 2020 04:39:59 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Duncan Laurie
dlaurie@chromium.org
Gerrit-MessageType: comment