28 Feb
2020
28 Feb
'20
2:12 a.m.
Rajat Jain has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39154 )
Change subject: drivers/gfx/generic: Add support for gpio based EPS ......................................................................
Patch Set 2:
(2 comments)
https://review.coreboot.org/c/coreboot/+/39154/1/src/drivers/gfx/generic/gen... File src/drivers/gfx/generic/generic.c:
https://review.coreboot.org/c/coreboot/+/39154/1/src/drivers/gfx/generic/gen... PS1, Line 89: /* EPS Disable */
code indent should use tabs where possible
Done
https://review.coreboot.org/c/coreboot/+/39154/1/src/drivers/gfx/generic/gen... PS1, Line 96: drivers_gfx_generic_privacy_screen_config *privacy)
need consistent spacing around '*' (ctx:WxV)
Done
--
To view, visit https://review.coreboot.org/c/coreboot/+/39154
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I6f570fd43e1649fb23255b0890e01086e34f844a
Gerrit-Change-Number: 39154
Gerrit-PatchSet: 2
Gerrit-Owner: Rajat Jain rajatja@google.com
Gerrit-Reviewer: Duncan Laurie dlaurie@chromium.org
Gerrit-Reviewer: Furquan Shaikh furquan@google.com
Gerrit-Reviewer: Mathew King mathewk@chromium.org
Gerrit-Reviewer: Rajat Jain rajatja@google.com
Gerrit-Reviewer: Shelley Chen shchen@google.com
Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Comment-Date: Fri, 28 Feb 2020 01:12:38 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: build bot (Jenkins) no-reply@coreboot.org
Gerrit-MessageType: comment