[coreboot-gerrit] Change in coreboot[master]: soc/intel/common/systemagent: Make common northbridge.asl

[Subrata Banik (Code Review)]

Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38456 )

Change subject: soc/intel/common/systemagent: Make common northbridge.asl
......................................................................

Patch Set 8:

(2 comments)

https://review.coreboot.org/c/coreboot/+/38456/4/src/soc/intel/common/block/... 
File src/soc/intel/common/block/systemagent/Kconfig:

https://review.coreboot.org/c/coreboot/+/38456/4/src/soc/intel/common/block/... 
PS4, Line 55: SOC_INTEL_COMMON_BLOCK_SA_VERSION_4 || SOC_INTEL_COMMON_BLOCK_SA_VERSION_5
> This can be replaced by a new boolean Kconfig symbol: SA_SUPPORTS_LARGE_PCIEX […]

Ack

https://review.coreboot.org/c/coreboot/+/38456/4/src/soc/intel/common/block/... 
File src/soc/intel/common/block/systemagent/systemagent_early.c:

https://review.coreboot.org/c/coreboot/+/38456/4/src/soc/intel/common/block/... 
PS4, Line 42: 	switch (CONFIG_SA_PCIEX_LENGTH) {
> are you telling to have a if check before case ? we already have CONFIG_SA_PCIEXBAR_LENGTH_BIT_WIDTH […]

Ack