Attention is currently required from: Furquan Shaikh, Patrick Rudolph. Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51359 )
Change subject: soc/intel/common/fast_spi: Fix check-fmap-16mib-crossing check ......................................................................
Patch Set 1: Code-Review+1
(4 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/51359/comment/5a0ac5ca_8cd8aeb6 PS1, Line 20: 32MiB 16MiB
Patchset:
PS1: Thanks for fixing this!
File src/soc/intel/common/block/fast_spi/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/51359/comment/f9505401_201b5206 PS1, Line 50: [[ Sorry, I guess this is a bashism, i.e. might not work in other shells. I guess one could write this as follows:
if [ $$flash_size -le $$((0x1000000)) ]; then
https://review.coreboot.org/c/coreboot/+/51359/comment/1bba5402_6c8cf4e7 PS1, Line 60: if [[ $$start -lt $$bios_16M_boundary && $$end -ge bios_16M_boundary ]]; then \ This should do:
if [ $$start -lt $$bios_16M_boundary ] && \ [ $$end -ge $$bios_16M_boundary ]; \ then \