Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33932 )
Change subject: mb/google/helios: Add ALC1011 in device tree to enable speaker amps
......................................................................
Patch Set 3:
(5 comments)
https://review.coreboot.org/c/coreboot/+/33932/1//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/33932/1//COMMIT_MSG@7
PS1, Line 7: in
to?
Done
https://review.coreboot.org/c/coreboot/+/33932/1//COMMIT_MSG@7
PS1, Line 7: Device tree
devicetree
Done
https://review.coreboot.org/c/coreboot/+/33932/1//COMMIT_MSG@9
PS1, Line 9: Following changes are done to enable ALC1011 codec on Helios
Ack
Done
https://review.coreboot.org/c/coreboot/+/33932/1//COMMIT_MSG@13
PS1, Line 13: Verified SSDT table and i2cdetect from kernel
Ack
Done
https://review.coreboot.org/c/coreboot/+/33932/1//COMMIT_MSG@16
PS1, Line 16:
Ack
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/33932
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I0d71e3bd2d4493d059a33023c1afe1b630181d4f
Gerrit-Change-Number: 33932
Gerrit-PatchSet: 3
Gerrit-Owner: Sathya Prakash M R
sathya.prakash.m.r@intel.com
Gerrit-Reviewer: Aamir Bohra
aamir.bohra@intel.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Naveen M
naveen.m@intel.com
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Sathya Prakash M R
sathya.prakash.m.r@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Fri, 19 Jul 2019 00:01:16 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Sathya Prakash M R
sathya.prakash.m.r@intel.com
Comment-In-Reply-To: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-MessageType: comment