Aamir Bohra has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41674 )
Change subject: soc/intel/common/block/sata: Fix SATA detection issue between Ports 3-7 ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/41674/1/src/soc/intel/common/block/... File src/soc/intel/common/block/sata/sata.c:
https://review.coreboot.org/c/coreboot/+/41674/1/src/soc/intel/common/block/... PS1, Line 44: port_impl &= 0xFF; /* bit 0-7 */ I think we can remove this line now. port_impl(u8) would be 8 bit read from config space.