Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/28104 )
Change subject: lib/fit_payload: Add coreboot tables support for FDT. ......................................................................
Patch Set 7: Code-Review+1
(3 comments)
https://review.coreboot.org/#/c/28104/7/src/lib/fit_payload.c File src/lib/fit_payload.c:
https://review.coreboot.org/#/c/28104/7/src/lib/fit_payload.c@103 PS7, Line 103: tables And strappings
https://review.coreboot.org/#/c/28104/7/src/lib/fit_payload.c@153 PS7, Line 153: userspace Why userspace ? I'd use the term payload here
https://review.coreboot.org/#/c/28104/7/src/lib/fit_payload.c@202 PS7, Line 202: add_cb_fdt_data(dt) Should be after dt_apply_fixups(), as it could remove and regenerate the whole devicetree.