Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35542 )
Change subject: soc/intel/skylake: devicetree: introduce PchHdaVcType fsp parameter ......................................................................
Patch Set 15:
Patch Set 15:
Patch Set 12:
I'm still curious why it needs to be one on some boards, even if the HDA is disabled. For me it sounds like a bug that's triggered somehow.
I tried disabling HDA for my asrock board + I did not install VC1 (VC0 is installed by default in FSP):
--- a/src/mainboard/asrock/h110m/devicetree.cb +++ b/src/mainboard/asrock/h110m/devicetree.cb @@ -53,7 +53,7 @@ chip soc/intel/skylake register "Device4Enable" = "1" register "SaGv" = "SaGv_Enabled" register "PmTimerDisabled" = "0"
register "EnableAzalia" = "1"
register "EnableAzalia" = "0" register "pirqa_routing" = "PCH_IRQ11"
@@ -426,7 +426,7 @@ chip soc/intel/skylake end # LPC Interface device pci 1f.1 on end # P2SB device pci 1f.2 on end # Power Management Controller
device pci 1f.3 on end # Intel HDA
device pci 1f.3 off end # Intel HDA device pci 1f.4 on end # SMBus params->CdClock = 3;
/* Enable Virtual Channel 1 */
params->PchHdaVcType = 0x1;
The OS is loading, but there is no sound
Patrick meant the bug that FSP crashes on some boards with EnableAzalia=0, PchHdaVcType=0, while it does not with EnableAzalia=0, PchHdaVcType=1. See the github bug ;)