Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35110 )
Change subject: soc/mediatek/mt8183: Run DRAM full calibration ......................................................................
Patch Set 52:
(4 comments)
https://review.coreboot.org/c/coreboot/+/35110/52/src/mainboard/google/kukui... File src/mainboard/google/kukui/romstage.c:
https://review.coreboot.org/c/coreboot/+/35110/52/src/mainboard/google/kukui... PS52, Line 28: CALIBRATION_REGION Please add a comment above:
/* This must be defined in chromeos.fmd in same name and size. */
https://review.coreboot.org/c/coreboot/+/35110/52/src/mainboard/google/kukui... PS52, Line 32: CALIBRATION_REGION does this really work? can you temporarily set REGION_SIZE to a smaller size and check?
We probably need to use #CALIBRATION_REGION instead?
https://review.coreboot.org/c/coreboot/+/35110/52/src/mainboard/google/kukui... PS52, Line 37: (void *) I wonder if we really need to do this cast? (void * should be converted automatically?)
https://review.coreboot.org/c/coreboot/+/35110/52/src/mainboard/google/kukui... PS52, Line 47: (void *) const void *