Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31709 )
Change subject: mainboard: Enable PRESERVE flag in all vboot/chromeos FMD files
......................................................................
Patch Set 5:
(3 comments)
https://review.coreboot.org/#/c/31709/3//COMMIT_MSG
Commit Message:
https://review.coreboot.org/#/c/31709/3//COMMIT_MSG@11
PS3, Line 11: RO_PRESERVE
: RO_VPD
: RW_PRESERVE
: RW_ELOG
: RW_NVRAM
: RW_SMMSTORE
: RW_VPD
: RO_FSG (b:116326638)
: SI_GBE (chromium:936768)
: SI_PDR (chromium:936768)
Make that a list?
Done
https://review.coreboot.org/#/c/31709/3//COMMIT_MSG@23
PS3, Line 23: future
in the future
Done
https://review.coreboot.org/#/c/31709/3//COMMIT_MSG@24
PS3, Line 24: need
needing?
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/31709
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I6664ae3d955001ed14374e2788d400ba5fb9b7f8
Gerrit-Change-Number: 31709
Gerrit-PatchSet: 5
Gerrit-Owner: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Duncan Laurie
dlaurie@chromium.org
Gerrit-Reviewer: Huang Jin
huang.jin@intel.com
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Philipp Deppenwiese
zaolin.daisuki@gmail.com
Gerrit-Reviewer: York Yang
york.yang@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Tue, 05 Mar 2019 13:40:13 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-MessageType: comment