Attention is currently required from: Felix Singer, Angel Pons.
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49193 )
Change subject: mb/hp/pavilion_m6_1035dx: Remove braces from single statement block
......................................................................
Patch Set 2:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/49193/comment/9a987229_48ae7c23
PS1, Line 7: mb/hp/pavilion_m6_1035dx: Remove braces from single statement block
Is there really a linter for this or is it checkpatch? […]
I don't remember if we came to any conclusion in [1]. Even if not, if there
are enough arguments to not warn about too many braces, I'd ack a patch that
removes that from checkpatch.
[1] [coreboot] More coding style change proposals
--
To view, visit
https://review.coreboot.org/c/coreboot/+/49193
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I05bd9e7fee16ed746ff234b1b2d5ffb99bb38c9e
Gerrit-Change-Number: 49193
Gerrit-PatchSet: 2
Gerrit-Owner: Felix Singer
felixsinger@posteo.net
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Angel Pons
th3fanbus@gmail.com
Gerrit-CC: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Felix Singer
felixsinger@posteo.net
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Comment-Date: Fri, 08 Jan 2021 18:16:15 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Felix Singer
felixsinger@posteo.net
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Gerrit-MessageType: comment